[PATCH] mxser: Remove commented crap

[PATCH] mxser: Remove commented crap

[Alan Cox]

This is years dead code and it keeps turning up in confusing ways when
grepping for stuff

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/char/mxser.c linux-2.6.23rc3-mm1/drivers/char/mxser.c
--- linux.vanilla-2.6.23rc3-mm1/drivers/char/mxser.c	2007-08-13 13:27:52.000000000 +0100
+++ linux-2.6.23rc3-mm1/drivers/char/mxser.c	2007-08-22 17:47:05.000000000 +0100
@@ -1938,14 +1938,6 @@
 				inb(info->base + UART_MSR);
 				continue;
 			}
-			/* above add by Victor Yu. 09-13-2002 */
-			/*
-			   if (info->tty->flip.count < TTY_FLIPBUF_SIZE / 4) {
-			   info->IER |= MOXA_MUST_RECV_ISR;
-			   outb(info->IER, info->base + UART_IER);
-			   }
-			 */
-
 
 			/* mask by Victor Yu. 09-13-2002
 			   if ( !info->tty ||
@@ -2599,19 +2591,8 @@
 		info->IER |= UART_IER_MSI;
 		if ((info->type == PORT_16550A) || (info->IsMoxaMustChipFlag)) {
 			info->MCR |= UART_MCR_AFE;
-			/* status = mxser_get_msr(info->base, 0, info->port); */
-/*
-	save_flags(flags);
-	cli();
-	status = inb(baseaddr + UART_MSR);
-	restore_flags(flags);
-*/
-			/* mxser_check_modem_status(info, status); */
 		} else {
-			/* status = mxser_get_msr(info->base, 0, info->port); */
-			/* MX_LOCK(&info->slock); */
 			status = inb(info->base + UART_MSR);
-			/* MX_UNLOCK(&info->slock); */
 			if (info->tty->hw_stopped) {
 				if (status & UART_MSR_CTS) {
 					info->tty->hw_stopped = 0;

Re: [PATCH] mxser: Remove commented crap

[Jeremy Fitzhardinge]

Alan Cox wrote:
> This is years dead code and it keeps turning up in confusing ways when
> grepping for stuff
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/char/mxser.c linux-2.6.23rc3-mm1/drivers/char/mxser.c
> --- linux.vanilla-2.6.23rc3-mm1/drivers/char/mxser.c	2007-08-13 13:27:52.000000000 +0100
> +++ linux-2.6.23rc3-mm1/drivers/char/mxser.c	2007-08-22 17:47:05.000000000 +0100
> @@ -1938,14 +1938,6 @@
>  				inb(info->base + UART_MSR);
>  				continue;
>  			}
> -			/* above add by Victor Yu. 09-13-2002 */
> -			/*
> -			   if (info->tty->flip.count < TTY_FLIPBUF_SIZE / 4) {
> -			   info->IER |= MOXA_MUST_RECV_ISR;
> -			   outb(info->IER, info->base + UART_IER);
> -			   }
> -			 */
> -
>  
>  			/* mask by Victor Yu. 09-13-2002
>  			   if ( !info->tty ||
>   

Looks like another block of commented code starting here...

    J