* [PATCH] x86 msr driver: Misc cpuinit annotations
@ 2007-08-22 23:50 Satyam Sharma
2007-08-23 22:52 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Satyam Sharma @ 2007-08-22 23:50 UTC (permalink / raw)
To: H Peter Anvin; +Cc: Andrew Morton, Linux Kernel Mailing List
msr_class_cpu_callback() can be marked __cpuinit, being the notifier
callback for a __cpuinitdata notifier_block. So can be marked
msr_device_create() too, called only from the newly-__cpuinit
msr_class_cpu_callback() or from __init-marked msr_init().
Signed-off-by: Satyam Sharma <satyam@infradead.org>
---
arch/i386/kernel/msr.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/i386/kernel/msr.c b/arch/i386/kernel/msr.c
index 0c1069b..ac55d85 100644
--- a/arch/i386/kernel/msr.c
+++ b/arch/i386/kernel/msr.c
@@ -135,7 +135,7 @@ static const struct file_operations msr_fops = {
.open = msr_open,
};
-static int msr_device_create(int i)
+static int __cpuinit msr_device_create(int i)
{
int err = 0;
struct device *dev;
@@ -146,7 +146,7 @@ static int msr_device_create(int i)
return err;
}
-static int msr_class_cpu_callback(struct notifier_block *nfb,
+static int __cpuinit msr_class_cpu_callback(struct notifier_block *nfb,
unsigned long action, void *hcpu)
{
unsigned int cpu = (unsigned long)hcpu;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86 msr driver: Misc cpuinit annotations
2007-08-22 23:50 [PATCH] x86 msr driver: Misc cpuinit annotations Satyam Sharma
@ 2007-08-23 22:52 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2007-08-23 22:52 UTC (permalink / raw)
To: Satyam Sharma; +Cc: Andrew Morton, Linux Kernel Mailing List
Satyam Sharma wrote:
> msr_class_cpu_callback() can be marked __cpuinit, being the notifier
> callback for a __cpuinitdata notifier_block. So can be marked
> msr_device_create() too, called only from the newly-__cpuinit
> msr_class_cpu_callback() or from __init-marked msr_init().
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
Acked-by: H. Peter Anvin <hpa@zytor.com>
> ---
>
> arch/i386/kernel/msr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/i386/kernel/msr.c b/arch/i386/kernel/msr.c
> index 0c1069b..ac55d85 100644
> --- a/arch/i386/kernel/msr.c
> +++ b/arch/i386/kernel/msr.c
> @@ -135,7 +135,7 @@ static const struct file_operations msr_fops = {
> .open = msr_open,
> };
>
> -static int msr_device_create(int i)
> +static int __cpuinit msr_device_create(int i)
> {
> int err = 0;
> struct device *dev;
> @@ -146,7 +146,7 @@ static int msr_device_create(int i)
> return err;
> }
>
> -static int msr_class_cpu_callback(struct notifier_block *nfb,
> +static int __cpuinit msr_class_cpu_callback(struct notifier_block *nfb,
> unsigned long action, void *hcpu)
> {
> unsigned int cpu = (unsigned long)hcpu;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-23 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-22 23:50 [PATCH] x86 msr driver: Misc cpuinit annotations Satyam Sharma
2007-08-23 22:52 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox