From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, ram.vepa@neterion.com,
santosh.rastapur@neterion.com, sivakumar.subramani@neterion.com,
sreenivasa.honnur@neterion.com, netdev@vger.kernel.org
Subject: Re: [PATCH 4/9] s2io, rename BIT macro
Date: Fri, 24 Aug 2007 04:35:40 +0200 [thread overview]
Message-ID: <46CE43FC.9040104@student.ltu.se> (raw)
In-Reply-To: <27692164102679012429@wsc.cz>
Jiri Slaby wrote:
> s2io, rename BIT macro
>
> BIT macro will be global definiton of (1<<x)
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ---
>
[snip]
> cnt++;
> if (cnt == 5)
> diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
> index 92983ee..448f899 100644
> --- a/drivers/net/s2io.h
> +++ b/drivers/net/s2io.h
> @@ -14,7 +14,7 @@
> #define _S2IO_H
>
> #define TBD 0
> -#define BIT(loc) (0x8000000000000000ULL >> (loc))
> +#define s2BIT(loc) (0x8000000000000000ULL >> (loc))
> #define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz))
> #define INV(d) ((d&0xff)<<24) | (((d>>8)&0xff)<<16) | (((d>>16)&0xff)<<8)| ((d>>24)&0xff)
>
>
Sorry for the late response, but would it not be better/easier to use
BIT() instead (or a global #define LLBIT(nr) (1ULL << (nr))) and just
recalculate the values?
Richard Knutsson
next prev parent reply other threads:[~2007-08-24 2:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-18 9:39 [PATCH 1/9] fs/select, remove unused macros Jiri Slaby
2007-08-18 9:40 ` [PATCH 2/9] cyber2000fb, rename BIT macro Jiri Slaby
2007-08-18 9:40 ` [PATCH 3/9] i2c-pxa, rename BIT macro to PXA_BIT Jiri Slaby
2007-08-18 9:41 ` [PATCH 4/9] s2io, rename BIT macro Jiri Slaby
2007-08-24 2:35 ` Richard Knutsson [this message]
2007-08-18 9:42 ` [PATCH 5/9] amba-pl011, " Jiri Slaby
2007-08-18 9:42 ` [PATCH 6/9] define first set of BIT* macros Jiri Slaby
2007-08-18 9:44 ` [PATCH 8/9] define global BIT macro Jiri Slaby
2007-08-18 16:46 ` Randy Dunlap
2007-08-18 17:13 ` Jiri Slaby
2007-08-18 18:15 ` Randy Dunlap
2007-08-22 22:03 ` Ralf Baechle
2007-08-18 9:44 ` [PATCH 9/9] FlashPoint, use BIT instead of BITW Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CE43FC.9040104@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox