From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, mingo@elte.hu,
dipankar@in.ibm.com, josht@linux.vnet.ibm.com, tytso@us.ibm.com,
dvhltc@us.ibm.com, tglx@linutronix.de
Subject: Re: [PATCH RFC] Priority boosting for preemptible RCU
Date: Fri, 24 Aug 2007 11:09:05 +0100 [thread overview]
Message-ID: <46CEAE41.7060001@shadowen.org> (raw)
In-Reply-To: <20070822124340.16a891f2.akpm@linux-foundation.org>
Andrew Morton wrote:
>> + for_each_possible_cpu(cpu) {
>> + rbdp = per_cpu(rcu_boost_dat, cpu);
>> + for (i = 0; i < RCU_BOOST_ELEMENTS; i++) {
>> + rbdp[i].rbs_mutex = SPIN_LOCK_UNLOCKED;
>
> Doesn't this confound lockdep? We're supposed to use spin_lock_init().
>
> Andy, can we have a checkpatch rule for SPIN_LOCK_UNLOCKED please? It's
> basically always wrong.
ERROR: Use of SPIN_LOCK_UNLOCKED is deprecated: see
Documentation/spinlocks.txt
#58: FILE: Z17.c:55:
+ rbdp[i].rbs_mutex = SPIN_LOCK_UNLOCKED;
Also picks up the RW_LOCK_UNLOCKED version too.
-apw
next prev parent reply other threads:[~2007-08-24 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 19:02 [PATCH RFC] Priority boosting for preemptible RCU Paul E. McKenney
2007-08-22 19:43 ` Andrew Morton
2007-08-22 20:23 ` Josh Triplett
2007-08-22 21:22 ` Paul E. McKenney
2007-08-22 21:41 ` Andrew Morton
2007-08-22 22:00 ` Paul E. McKenney
2007-08-24 10:09 ` Andy Whitcroft [this message]
2007-08-23 4:26 ` Gautham R Shenoy
2007-08-23 8:54 ` Paul E. McKenney
2007-08-23 10:14 ` Gautham R Shenoy
2007-08-23 13:15 ` Paul E. McKenney
2007-08-23 14:22 ` Gautham R Shenoy
2007-08-23 15:55 ` Paul E. McKenney
2007-08-24 8:21 ` Gautham R Shenoy
2007-08-24 17:27 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CEAE41.7060001@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josht@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tytso@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox