Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

Divy Le Ray
2007-08-28T21:25:29Z

Roland Dreier wrote:
> > I take that back. Rejected -- it breaks infiniband build.
>
> To be more precise:
>
> drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open':
> drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV'
>
> it seems the problem is that T3CDEV() has been deleted and been
> replaced with the dev2t3cdev() inline function. However a simple
> replacement s/T3CDEV/dev2t3cdev/ in drivers/infiniband/hw/cxgb3
> doesn't work because the function has moved from t3cdev.h to
> adapter.h; and moving the function back to t3cdev.h doesn't work
> because it depends on more structure definitions now.
>
> And at that point I gave up...
>

Sorry about the compilation issue and the delay to reply.
I'll post a follow up for the iw_cxgb3 driver later this evening.
I plan to move the inlined dev2t3cdev() from adapter.h to an exported
dev2t3cdev()
in cxgb3_offload.c.

Divy