public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	ananth@in.ibm.com, prasanna@in.ibm.com,
	anil.s.keshavamurthy@intel.com,
	Jim Keniston <jkenisto@us.ibm.com>,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	systemtap-ml <systemtap@sources.redhat.com>
Subject: Re: [PATCH][kprobes] support kretprobe-blacklist
Date: Mon, 27 Aug 2007 11:49:21 -0400	[thread overview]
Message-ID: <46D2F281.5030305@redhat.com> (raw)
In-Reply-To: <20070827133154.GA22322@infradead.org>

Hi Christoph,

Christoph Hellwig wrote:
> On Fri, Aug 17, 2007 at 03:43:04PM -0400, Masami Hiramatsu wrote:
>> This patch introduces architecture dependent kretprobe
>> blacklists to prohibit users from inserting return
>> probes on the function in which kprobes can be inserted
>> but kretprobes can not.
> 
> I don't like this at all.  If people want to shoot themselves into
> their own foot using kernel modules they have an unlimited number
> of ways to do this, and even more with kprobes, so there's no point
> in making it a little harder for some cases.

Would you mean that the kernel need not to check whether the probe
point is safe or not?

Actually, there are many ways to shoot themselves from kernel modules.
Even so, IMHO, it is benefit for people that the kernel rejects at least
those obviously (and known) dangerous operation.

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com

      reply	other threads:[~2007-08-27 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17 19:43 [PATCH][kprobes] support kretprobe-blacklist Masami Hiramatsu
2007-08-17 22:03 ` Andrew Morton
2007-08-17 23:08   ` Masami Hiramatsu
2007-08-21 21:01   ` [PATCH][kprobes] support kretprobe-blacklist take2 Masami Hiramatsu
2007-08-23  4:12     ` Ananth N Mavinakayanahalli
2007-08-27 13:31 ` [PATCH][kprobes] support kretprobe-blacklist Christoph Hellwig
2007-08-27 15:49   ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D2F281.5030305@redhat.com \
    --to=mhiramat@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasanna@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox