From: Divy Le Ray <divy@chelsio.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com
Subject: Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage
Date: Tue, 28 Aug 2007 14:24:55 -0700 [thread overview]
Message-ID: <46D492A7.8040301@chelsio.com> (raw)
In-Reply-To: <adahcmjcqca.fsf@cisco.com>
Roland Dreier wrote:
> > I take that back. Rejected -- it breaks infiniband build.
>
> To be more precise:
>
> drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open':
> drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV'
>
> it seems the problem is that T3CDEV() has been deleted and been
> replaced with the dev2t3cdev() inline function. However a simple
> replacement s/T3CDEV/dev2t3cdev/ in drivers/infiniband/hw/cxgb3
> doesn't work because the function has moved from t3cdev.h to
> adapter.h; and moving the function back to t3cdev.h doesn't work
> because it depends on more structure definitions now.
>
> And at that point I gave up...
>
Sorry about the compilation issue and the delay to reply.
I'll post a follow up for the iw_cxgb3 driver later this evening.
I plan to move the inlined dev2t3cdev() from adapter.h to an exported
dev2t3cdev()
in cxgb3_offload.c.
Divy
prev parent reply other threads:[~2007-08-28 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 22:06 [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage Divy Le Ray
2007-08-25 3:58 ` Jeff Garzik
2007-08-25 6:31 ` Jeff Garzik
2007-08-28 21:16 ` Roland Dreier
2007-08-28 21:24 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D492A7.8040301@chelsio.com \
--to=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox