public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	bugme-daemon@bugzilla.kernel.org, linux-kernel@vger.kernel.org,
	mattilinnanvuori@yahoo.com
Subject: Re: [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes
Date: Wed, 29 Aug 2007 19:33:48 -0600	[thread overview]
Message-ID: <46D61E7C.20304@shaw.ca> (raw)
In-Reply-To: <fa.+esfGGdgETnuZiuGXcL9U8IpoNM@ifi.uio.no>

Andrew Morton wrote:
> On Wed, 29 Aug 2007 11:33:06 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:
> 
>> http://bugzilla.kernel.org/show_bug.cgi?id=8957
>>
>>            Summary: Exported functions and variables should not be reachable
>>                     by the outside of the module until module_init finishes
>>            Product: Other
>>            Version: 2.5
>>      KernelVersion: 2.6.23-rc4
>>           Platform: All
>>         OS/Version: Linux
>>               Tree: Mainline
>>             Status: NEW
>>           Severity: normal
>>           Priority: P1
>>          Component: Modules
>>         AssignedTo: other_modules@kernel-bugs.osdl.org
>>         ReportedBy: mattilinnanvuori@yahoo.com
>>
>>
>> Problem Description: a module's exported functions can be called before before
>> they are properly initialized by the module_init function.
>>
>> Steps to reproduce: write a module that exports functions that require
>> initialization by the module_init function to work correctly.
>>
>> E.g. spin lock variables are no longer allowed to be initialized by C
>> initializers of the module but only by spin_lock_init that can be called by the
>> module_init function. If an exported function calls spin_lock before it is
>> initialized, it deadlocks.
>>
> 
> ooh, nice bug ;)

Under what circumstances is this actually happening? What are these 
functions that are being called?

Normally things are set up such that this isn't a problem, i.e. if 
module A depends on module B, module A can't load until module B is 
finished loading.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


       reply	other threads:[~2007-08-30  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.fGbKfAxvHbZD1OUm5bpknraMlkQ@ifi.uio.no>
     [not found] ` <fa.+esfGGdgETnuZiuGXcL9U8IpoNM@ifi.uio.no>
2007-08-30  1:33   ` Robert Hancock [this message]
2007-08-30  2:10     ` [Bugme-new] [Bug 8957] New: Exported functions and variables should not be reachable by the outside of the module until module_init finishes Andrew Morton
2007-08-31 15:54       ` Satyam Sharma
2007-08-30 17:35     ` Satyam Sharma
     [not found] <bug-8957-10286@http.bugzilla.kernel.org/>
2007-08-29 23:23 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D61E7C.20304@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattilinnanvuori@yahoo.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox