public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] Override 80-wire cable detection for Toshiba S1800-814
@ 2007-08-30  4:31 Al Boldi
  2007-08-30 10:01 ` Alan Cox
  0 siblings, 1 reply; 10+ messages in thread
From: Al Boldi @ 2007-08-30  4:31 UTC (permalink / raw)
  To: linux-kernel; +Cc: dex

Alan Cox wrote:
> Daniel Exner <dex@dragonslave.de> wrote:
>> Attached patch will add above mentioned Laptop Model to whitelist for both 
>> pata_ali and alim15x3, as it is correctly detected as 40-wire connected
>> but this cable is short enough to still do transfers higher than UDMA33.
>
> Looks good to me - does need a Signed-off-by: line however

Wow!  I have been running 80wire cable detection override on 40wire cables 
for quite some time without any problem, but I never thought it to be legal 
if the 40wire cable length is short enough.

How short does it have to be, and can't we have a kernel bootparm to override 
the cable detection?


Thanks!

--
Al


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] Override 80-wire cable detection for Toshiba S1800-814
@ 2007-08-29 21:41 Daniel Exner
  2007-08-29 21:59 ` Alan Cox
  0 siblings, 1 reply; 10+ messages in thread
From: Daniel Exner @ 2007-08-29 21:41 UTC (permalink / raw)
  To: linux-kernel; +Cc: Alan Cox

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

Attached patch will add above mentioned Laptop Model to whitelist for both 
pata_ali and alim15x3, as it is correctly detected as 40-wire connected but 
this cable is short enough to still do transfers higher than UDMA33.
Don't know if this is also true for other S1800 Laptops cause I own only one.

I hope I did this correctly as this is my first Patch Mail to LKML :)
-- 
Greetings
Daniel Exner

[-- Attachment #2: patchAli_pata.patch --]
[-- Type: text/x-diff, Size: 840 bytes --]

--- linux-2.6.22.old/drivers/ata/pata_ali.c	2007-08-29 23:27:53.000000000 +0200
+++ linux-2.6.22/drivers/ata/pata_ali.c	2007-08-29 23:14:37.000000000 +0200
@@ -48,6 +48,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satelite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	}, 
 	{ }
 };
 
--- linux-2.6.22.old/drivers/ide/pci/alim15x3.c	2007-08-29 22:17:14.000000000 +0200
+++ linux-2.6.22/drivers/ide/pci/alim15x3.c	2007-08-29 22:56:27.000000000 +0200
@@ -596,6 +596,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satellite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	},
 	{ }
 };
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2007-08-30 23:14 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <fa.aDOpPGIWVD3AP0+s8JbykPNWRao@ifi.uio.no>
     [not found] ` <fa.f0bdB2EM6R3BhlpkdSTPMRlJu9U@ifi.uio.no>
     [not found]   ` <fa.xZcOyxsTcgfWflTXq8DY8M1ncqc@ifi.uio.no>
2007-08-30 14:29     ` [PATCH] Override 80-wire cable detection for Toshiba S1800-814 Robert Hancock
2007-08-30  4:31 Al Boldi
2007-08-30 10:01 ` Alan Cox
2007-08-30 13:54   ` Al Boldi
2007-08-30 19:38     ` Jan Engelhardt
2007-08-30 19:47       ` Lennart Sorensen
2007-08-30 19:52         ` Jan Engelhardt
2007-08-30 23:22     ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2007-08-29 21:41 Daniel Exner
2007-08-29 21:59 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox