From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386 and x86_64: randomize brk()
Date: Thu, 30 Aug 2007 17:33:03 +0200 [thread overview]
Message-ID: <46D6E32F.30204@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708301708590.4135@jikos.suse.cz>
Jiri Kosina wrote:
> On Thu, 30 Aug 2007, Mike Frysinger wrote:
>
>> Blackfin too please :) i think v850 also falls into this category, but
>> i'm not terribly familiar with it ...
>
> Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK
> macro instead please?
>
you might want to use a weak function instead ?
void __weak arch_randomize_brk(void)
{
/* nada by default */
}
and overload it only for x86 architectures by now.
BTW, how about minimize the arch specific code by slighly changing its
prototype ?
unsigned long arch_randomize_brk(struct mm_struct *mm)
{
unsigned long range_end = mm->brk + 0x02000000;
return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
}
Franck
next prev parent reply other threads:[~2007-08-30 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 13:47 [PATCH] i386 and x86_64: randomize brk() Jiri Kosina
2007-08-30 14:01 ` Mike Frysinger
2007-08-30 14:21 ` Jiri Kosina
2007-08-30 14:26 ` Mike Frysinger
2007-08-30 15:10 ` Jiri Kosina
2007-08-30 15:33 ` Franck Bui-Huu [this message]
2007-08-31 1:05 ` Andrew Morton
2007-08-31 11:56 ` Jiri Kosina
2007-09-01 20:19 ` Franck Bui-Huu
2007-09-02 20:28 ` Andrew Morton
2007-09-03 9:34 ` Jiri Kosina
2007-09-03 10:03 ` Jiri Kosina
2007-09-03 17:38 ` Franck Bui-Huu
2007-09-03 20:44 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2007-08-22 16:05 Jiri Kosina
2007-08-22 22:58 ` Andrew Morton
2007-08-22 23:04 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D6E32F.30204@gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox