Re: Linux 2.6.23-rc4: BAD regression

Re: Linux 2.6.23-rc4: BAD regression

[Daniel Ritz]

tried that one on my old toshiba tecra 8000 laptop, almost killing it.
the fan doesn't work any more...type 'make' and see the box dying.
luckily my CPU doesn't commit suicide...bisected it to that one:

cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Fri Aug 3 17:52:48 2007 -0400

    ACPI: EC: If ECDT is not found, look up EC in DSDT.

    Some ASUS laptops access EC space from device _INI methods, but do not
    provide ECDT for early EC setup. In order to make them function properly,
    there is a need to find EC is DSDT before any _INI is called.

    Similar functionality was turned on by acpi_fake_ecdt=1 command line
    before. Now it is on all the time.

    http://bugzilla.kernel.org/show_bug.cgi?id=8598

    Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: Len Brown <len.brown@intel.com>

Re: Linux 2.6.23-rc4: BAD regression

[Linus Torvalds]

Len? Should we just revert it?

That commit has been very painful. First it lost all registration of the 
query methods, and now this.

Daniel - can we please have a before/after dmesg on your machine, 
preferably with ACPI debugging enabled? And for ACPI stuff, it usually 
does help to fill in a bugzilla entry, since the ACPI people actually do 
track things there...

		Linus

On Wed, 29 Aug 2007, Daniel Ritz wrote:
>
> tried that one on my old toshiba tecra 8000 laptop, almost killing it.
> the fan doesn't work any more...type 'make' and see the box dying.
> luckily my CPU doesn't commit suicide...bisected it to that one:
> 
> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
> commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
> Author: Alexey Starikovskiy <astarikovskiy@suse.de>
> Date:   Fri Aug 3 17:52:48 2007 -0400
> 
>     ACPI: EC: If ECDT is not found, look up EC in DSDT.
> 
>     Some ASUS laptops access EC space from device _INI methods, but do not
>     provide ECDT for early EC setup. In order to make them function properly,
>     there is a need to find EC is DSDT before any _INI is called.
> 
>     Similar functionality was turned on by acpi_fake_ecdt=1 command line
>     before. Now it is on all the time.
> 
>     http://bugzilla.kernel.org/show_bug.cgi?id=8598
> 
>     Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>     Signed-off-by: Len Brown <len.brown@intel.com>
> 

Re: Linux 2.6.23-rc4: BAD regression

[Alexey Starikovskiy]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

Daniel,
Does this patch help you, or do we need to revert the whole thing?

Sorry for the trouble,
Alex.
Daniel Ritz wrote:
> tried that one on my old toshiba tecra 8000 laptop, almost killing it.
> the fan doesn't work any more...type 'make' and see the box dying.
> luckily my CPU doesn't commit suicide...bisected it to that one:
>
> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
> commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
> Author: Alexey Starikovskiy <astarikovskiy@suse.de>
> Date:   Fri Aug 3 17:52:48 2007 -0400
>
>     ACPI: EC: If ECDT is not found, look up EC in DSDT.
>
>     Some ASUS laptops access EC space from device _INI methods, but do not
>     provide ECDT for early EC setup. In order to make them function properly,
>     there is a need to find EC is DSDT before any _INI is called.
>
>     Similar functionality was turned on by acpi_fake_ecdt=1 command line
>     before. Now it is on all the time.
>
>     http://bugzilla.kernel.org/show_bug.cgi?id=8598
>
>     Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>     Signed-off-by: Len Brown <len.brown@intel.com>
>   


[-- Attachment #2: drop_ec_early_init_from_DSDT.patch --]
[-- Type: text/x-patch, Size: 1345 bytes --]

Drop early init of EC from DSDT patch

From: Alexey Starikovskiy <astarikovskiy@suse.de>


---

 drivers/acpi/ec.c |   21 +++++++--------------
 1 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 43749c8..e28f5b2 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -876,20 +876,13 @@ int __init acpi_ec_ecdt_probe(void)
 	 */
 	status = acpi_get_table(ACPI_SIG_ECDT, 1,
 				(struct acpi_table_header **)&ecdt_ptr);
-	if (ACPI_SUCCESS(status)) {
-		printk(KERN_INFO PREFIX "EC description table is found, configuring boot EC\n\n");
-		boot_ec->command_addr = ecdt_ptr->control.address;
-		boot_ec->data_addr = ecdt_ptr->data.address;
-		boot_ec->gpe = ecdt_ptr->gpe;
-		boot_ec->handle = ACPI_ROOT_OBJECT;
-	} else {
-		printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
-		status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
-						boot_ec, NULL);
-		if (ACPI_FAILURE(status))
-			goto error;
-	}
-
+	if (ACPI_FAILURE(status))
+		goto error;
+	printk(KERN_INFO PREFIX "EC description table is found, configuring boot EC\n");
+	boot_ec->command_addr = ecdt_ptr->control.address;
+	boot_ec->data_addr = ecdt_ptr->data.address;
+	boot_ec->gpe = ecdt_ptr->gpe;
+	boot_ec->handle = ACPI_ROOT_OBJECT;
 	ret = ec_install_handlers(boot_ec);
 	if (!ret) {
 		first_ec = boot_ec;

Re: Linux 2.6.23-rc4: BAD regression

[Daniel Ritz]

On Wednesday 29 August 2007 06:41:41 Alexey Starikovskiy wrote:
> Daniel,
> Does this patch help you, or do we need to revert the whole thing?
> 

yes, this does the trick. the fan goes on again. thanks.
if you still need additional debug output or if you want me to test
a different patch just let me know.

rgds
-daniel

> Sorry for the trouble,
> Alex.
> Daniel Ritz wrote:
> > tried that one on my old toshiba tecra 8000 laptop, almost killing it.
> > the fan doesn't work any more...type 'make' and see the box dying.
> > luckily my CPU doesn't commit suicide...bisected it to that one:
> >
> > cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
> > commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
> > Author: Alexey Starikovskiy <astarikovskiy@suse.de>
> > Date:   Fri Aug 3 17:52:48 2007 -0400
> >
> >     ACPI: EC: If ECDT is not found, look up EC in DSDT.
> >
> >     Some ASUS laptops access EC space from device _INI methods, but do not
> >     provide ECDT for early EC setup. In order to make them function properly,
> >     there is a need to find EC is DSDT before any _INI is called.
> >
> >     Similar functionality was turned on by acpi_fake_ecdt=1 command line
> >     before. Now it is on all the time.
> >
> >     http://bugzilla.kernel.org/show_bug.cgi?id=8598
> >
> >     Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> >     Signed-off-by: Len Brown <len.brown@intel.com>
> >   

Re: Linux 2.6.23-rc4: BAD regression

[Alexey Starikovskiy]

If you could open a bugreport at bugzilla.kernel.org in ACPI category
and attach
dmesg and acpidump output, that would help a lot. (I hope :( )

Thanks,
Alex.

Daniel Ritz wrote:
> On Wednesday 29 August 2007 06:41:41 Alexey Starikovskiy wrote:
>   
>> Daniel,
>> Does this patch help you, or do we need to revert the whole thing?
>>
>>     
>
> yes, this does the trick. the fan goes on again. thanks.
> if you still need additional debug output or if you want me to test
> a different patch just let me know.
>
> rgds
> -daniel
>
>   
>> Sorry for the trouble,
>> Alex.
>> Daniel Ritz wrote:
>>     
>>> tried that one on my old toshiba tecra 8000 laptop, almost killing it.
>>> the fan doesn't work any more...type 'make' and see the box dying.
>>> luckily my CPU doesn't commit suicide...bisected it to that one:
>>>
>>> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
>>> commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
>>> Author: Alexey Starikovskiy <astarikovskiy@suse.de>
>>> Date:   Fri Aug 3 17:52:48 2007 -0400
>>>
>>>     ACPI: EC: If ECDT is not found, look up EC in DSDT.
>>>
>>>     Some ASUS laptops access EC space from device _INI methods, but do not
>>>     provide ECDT for early EC setup. In order to make them function properly,
>>>     there is a need to find EC is DSDT before any _INI is called.
>>>
>>>     Similar functionality was turned on by acpi_fake_ecdt=1 command line
>>>     before. Now it is on all the time.
>>>
>>>     http://bugzilla.kernel.org/show_bug.cgi?id=8598
>>>
>>>     Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>>>     Signed-off-by: Len Brown <len.brown@intel.com>
>>>   
>>>       
>
>
>   

Re: Linux 2.6.23-rc4: BAD regression

[Daniel Ritz]

On Wednesday 29 August 2007 21:45:01 Alexey Starikovskiy wrote:
> If you could open a bugreport at bugzilla.kernel.org in ACPI category
> and attach
> dmesg and acpidump output, that would help a lot. (I hope :( )
> 

done. http://bugzilla.kernel.org/show_bug.cgi?id=8958

> Thanks,
> Alex.
> 
> Daniel Ritz wrote:
> > On Wednesday 29 August 2007 06:41:41 Alexey Starikovskiy wrote:
> >   
> >> Daniel,
> >> Does this patch help you, or do we need to revert the whole thing?
> >>
> >>     
> >
> > yes, this does the trick. the fan goes on again. thanks.
> > if you still need additional debug output or if you want me to test
> > a different patch just let me know.
> >
> > rgds
> > -daniel
> >
> >   
> >> Sorry for the trouble,
> >> Alex.
> >> Daniel Ritz wrote:
> >>     
> >>> tried that one on my old toshiba tecra 8000 laptop, almost killing it.
> >>> the fan doesn't work any more...type 'make' and see the box dying.
> >>> luckily my CPU doesn't commit suicide...bisected it to that one:
> >>>
> >>> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
> >>> commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
> >>> Author: Alexey Starikovskiy <astarikovskiy@suse.de>
> >>> Date:   Fri Aug 3 17:52:48 2007 -0400
> >>>
> >>>     ACPI: EC: If ECDT is not found, look up EC in DSDT.
> >>>
> >>>     Some ASUS laptops access EC space from device _INI methods, but do not
> >>>     provide ECDT for early EC setup. In order to make them function properly,
> >>>     there is a need to find EC is DSDT before any _INI is called.
> >>>
> >>>     Similar functionality was turned on by acpi_fake_ecdt=1 command line
> >>>     before. Now it is on all the time.
> >>>
> >>>     http://bugzilla.kernel.org/show_bug.cgi?id=8598
> >>>
> >>>     Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> >>>     Signed-off-by: Len Brown <len.brown@intel.com>
> >>>   
> >>>       
> >
> >
> >   
> 
> 

Re: Linux 2.6.23-rc4: BAD regression

[Luca Tettamanti]

Il Wed, Aug 29, 2007 at 01:29:56AM +0200, Daniel Ritz ha scritto: 
> tried that one on my old toshiba tecra 8000 laptop, almost killing it.
> the fan doesn't work any more...type 'make' and see the box dying.
> luckily my CPU doesn't commit suicide...bisected it to that one:
> 
> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit

I've just bisected down to the same commit. In my case the fan is locked
at maximum speed and the system is *extremly* slow (some kind of
throttling?).

Alexey, I've seen the patch, I'll test it tomorrow and report back.

Luca
-- 
Tentare e` il primo passo verso il fallimento.
Homer J. Simpson

Re: Linux 2.6.23-rc4: BAD regression

[Daniel Ritz]

On Thursday 30 August 2007 01:21:50 Luca Tettamanti wrote:
> Il Wed, Aug 29, 2007 at 01:29:56AM +0200, Daniel Ritz ha scritto: 
> > tried that one on my old toshiba tecra 8000 laptop, almost killing it.
> > the fan doesn't work any more...type 'make' and see the box dying.
> > luckily my CPU doesn't commit suicide...bisected it to that one:
> > 
> > cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
> 
> I've just bisected down to the same commit. In my case the fan is locked
> at maximum speed and the system is *extremly* slow (some kind of
> throttling?).
> 
> Alexey, I've seen the patch, I'll test it tomorrow and report back.
> 

i've just tested the minimal fix here:
	http://bugzilla.kernel.org/show_bug.cgi?id=8958#c7
works good so far. fan starts and system is responsive.

> Luca

rgds
-daniel

Re: Linux 2.6.23-rc4: BAD regression

[Linus Torvalds]

On Thu, 30 Aug 2007, Daniel Ritz wrote:
> 
> i've just tested the minimal fix here:
> 	http://bugzilla.kernel.org/show_bug.cgi?id=8958#c7
> works good so far. fan starts and system is responsive.

Alexey, Len, can we get this fix integrated asap?

		Linus

Re: Linux 2.6.23-rc4: BAD regression

[Luca]

On 8/30/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Thu, 30 Aug 2007, Daniel Ritz wrote:
> >
> > i've just tested the minimal fix here:
> >       http://bugzilla.kernel.org/show_bug.cgi?id=8958#c7
> > works good so far. fan starts and system is responsive.
>
> Alexey, Len, can we get this fix integrated asap?

Tested here, works fine.

Luca

[PATCH] ACPI: EC: Check if boot_ec was really found in DSDT

[Alexey Starikovskiy]

From: Alexey Starikovskiy <astarikovskiy@suse.de>

acpi_get_devices() returns success if it did not find any device.
We have to check for this case.

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/ec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 43749c8..3f7935a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -886,7 +886,8 @@ int __init acpi_ec_ecdt_probe(void)
         printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
         status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
                         boot_ec, NULL);
-        if (ACPI_FAILURE(status))
+        /* Check that acpi_get_devices actually find something */
+        if (ACPI_FAILURE(status) || !boot_ec->handle)
             goto error;
     }
 

Re: [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT

[Linus Torvalds]

On Fri, 31 Aug 2007, Alexey Starikovskiy wrote:
> 
> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>

This was totally whitespace-damaged. You have some broken email client 
that turns <tab>s into four spaces.

May I suggest rethinking the use of Thunderbird (aka "mangles things 
ridiculously")?

Anyway, I fixed it up and applied it.

		Linus

Re: [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT

[Alexey Starikovskiy]

Linus Torvalds wrote:
> On Fri, 31 Aug 2007, Alexey Starikovskiy wrote:
>   
>> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>>     
>
> This was totally whitespace-damaged. You have some broken email client 
> that turns <tab>s into four spaces.
>
> May I suggest rethinking the use of Thunderbird (aka "mangles things 
> ridiculously")?
>
> Anyway, I fixed it up and applied it.
>
> 		Linus
>   
Thanks, what client do you use/recommend?

Alex.

Re: [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT

[Andrew Morton]

On Fri, 31 Aug 2007 09:29:07 +0400 Alexey Starikovskiy <astarikovskiy@suse.de> wrote:

> Linus Torvalds wrote:
> > On Fri, 31 Aug 2007, Alexey Starikovskiy wrote:
> >   
> >> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> >>     
> >
> > This was totally whitespace-damaged. You have some broken email client 
> > that turns <tab>s into four spaces.
> >
> > May I suggest rethinking the use of Thunderbird (aka "mangles things 
> > ridiculously")?
> >
> > Anyway, I fixed it up and applied it.
> >
> > 		Linus
> >   
> Thanks, what client do you use/recommend?
> 

I use sylpheed.  thunderbird can be used, but one needs to follow
the steps in http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
to get it out of i-know-better mode.

Re: mail client to send patches

[Alexey Starikovskiy]

Andrew Morton wrote:
> On Fri, 31 Aug 2007 09:29:07 +0400 Alexey Starikovskiy <astarikovskiy@suse.de> wrote:
> 
>> Linus Torvalds wrote:
>>> On Fri, 31 Aug 2007, Alexey Starikovskiy wrote:
>>>   
>>>> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>>>>     
>>> This was totally whitespace-damaged. You have some broken email client 
>>> that turns <tab>s into four spaces.
>>>
>>> May I suggest rethinking the use of Thunderbird (aka "mangles things 
>>> ridiculously")?
>>>
>>> Anyway, I fixed it up and applied it.
>>>
>>> 		Linus
>>>   
>> Thanks, what client do you use/recommend?
>>
> 
> I use sylpheed.  thunderbird can be used, but one needs to follow
> the steps in http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
> to get it out of i-know-better mode.
Thanks. I seem to have missed that Thunderbird has compose preference
different for each mail account. 

Re: [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT

[Jeff Garzik]

Andrew Morton wrote:
> I use sylpheed.  thunderbird can be used, but one needs to follow
> the steps in http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
> to get it out of i-know-better mode.


Can we get something like this into the kernel tree, please?

Documentation/email-clients.txt would go a long way towards making our 
collective lives more simple.

	Jeff