From: Jeff Garzik <jeff@garzik.org>
To: Grant Wilson <grant.wilson@zen.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: Linux 2.6.23-rc5 - oops
Date: Sat, 01 Sep 2007 06:32:00 -0400 [thread overview]
Message-ID: <46D93FA0.1000307@garzik.org> (raw)
In-Reply-To: <20070901101110.038835c2@worthy.swandive.local>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
Grant Wilson wrote:
> Get an oops when booting this kernel:
[...]
> Using git-bisect the faulty commit is
>
> bad: [43a98f05d99205687ddf74089e79a8312c8c5f90] ata_piix: implement IOCFG bit18 quirk
Good work bisecting! I love git-bisect :)
The attached patch should fix things, let me know if it does not.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 547 bytes --]
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index e40c94f..3b8bf18 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -955,7 +955,8 @@ static int piix_broken_suspend(void)
DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE M500"),
},
},
- { }
+
+ { } /* terminate list */
};
static const char *oemstrs[] = {
"Tecra M3,",
@@ -1187,6 +1188,8 @@ static void piix_iocfg_bit18_quirk(struct pci_dev *pdev)
DMI_MATCH(DMI_PRODUCT_NAME, "M570U"),
},
},
+
+ { } /* terminate list */
};
u32 iocfg;
next prev parent reply other threads:[~2007-09-01 10:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 6:52 Linux 2.6.23-rc5 Linus Torvalds
2007-09-01 9:11 ` Linux 2.6.23-rc5 - oops Grant Wilson
2007-09-01 10:20 ` Cyrill Gorcunov
2007-09-01 10:32 ` Jeff Garzik
2007-09-01 10:37 ` Cyrill Gorcunov
[not found] ` <1188817911.5333.8.camel@zv.wilibox.com>
2007-09-03 13:09 ` Cyrill Gorcunov
2007-09-01 10:32 ` Jeff Garzik [this message]
2007-09-02 7:54 ` Linux 2.6.23-rc5 Prakash Punnoor
2007-09-02 9:49 ` Rafael J. Wysocki
2007-09-03 18:32 ` Gabriel C
2007-09-03 21:24 ` Alessandro Suardi
2007-09-03 21:41 ` Gabriel C
2007-09-04 16:20 ` Prakash Punnoor
2007-09-04 16:10 ` S.Çağlar Onur
2007-09-04 16:32 ` S.Çağlar Onur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D93FA0.1000307@garzik.org \
--to=jeff@garzik.org \
--cc=grant.wilson@zen.co.uk \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox