From: Jeff Garzik <jeff@garzik.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/x86-64 PCI domain support
Date: Sun, 02 Sep 2007 12:56:56 -0400 [thread overview]
Message-ID: <46DAEB58.3070109@garzik.org> (raw)
In-Reply-To: <20070902094637.6750f068.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote:
>
>> Andi Kleen wrote:
>>>>> The second function is redundant?
>>>> No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled.
>>> Then the other function is redundant.
>> No, both functions are required by the interface.
>
> by what interface? and why, please? (instead of just stating "required")
grep for CONFIG_PCI_DOMAINS in arch code and include/linux/pci.h.
This is normal "arch" interface: you enable a define, and a group of
functions is assumed to be present. Otherwise (!defined), a set of stub
no-ops is activated for your arch.
I have implemented the [small] group of functions the code assumes to be
present, when CONFIG_PCI_DOMAINS is enabled, like all the other arches
that implement PCI domain support.
Jeff
next prev parent reply other threads:[~2007-09-02 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 14:32 [PATCH] x86/x86-64 PCI domain support Jeff Garzik
2007-09-01 22:00 ` Andi Kleen
2007-09-01 22:06 ` Jeff Garzik
2007-09-01 22:26 ` Andi Kleen
2007-09-01 22:40 ` Jeff Garzik
2007-09-02 16:46 ` Randy Dunlap
2007-09-02 16:56 ` Jeff Garzik [this message]
2007-09-02 17:15 ` Randy Dunlap
2007-09-02 9:19 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DAEB58.3070109@garzik.org \
--to=jeff@garzik.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox