From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbXIBUXf (ORCPT ); Sun, 2 Sep 2007 16:23:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751384AbXIBUXI (ORCPT ); Sun, 2 Sep 2007 16:23:08 -0400 Received: from gateway-1237.mvista.com ([63.81.120.155]:54548 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750816AbXIBUXF (ORCPT ); Sun, 2 Sep 2007 16:23:05 -0400 Message-ID: <46DB1C50.2020205@ru.mvista.com> Date: Mon, 03 Sep 2007 00:25:52 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: bzolnier@gmail.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards References: <200709030019.22732.sshtylyov@ru.mvista.com> In-Reply-To: <200709030019.22732.sshtylyov@ru.mvista.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello, I wrote: The patch was 4/4 of course. :-< Probably I was too esctatic about the code. ;-) > The Marvell bridge chips used on HighPoint SATA cards do not seem to support > the MWDMA modes (at least that caould be seen in their so-called drivers :-), > so the driver needs to account for this -- to achieve this: > - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz > with his consent, also adding the method callout to ide_rate_filter(); > - installed the method for all chips to only return empty mask if a SATA drive > is detected onHPT372{AN]/374 chips... > Signed-off-by: Sergei Shtylyov > --- > This patch against the current Linus' tree and unfortunately I was able to only > compile test it since that tree gives MODPOST warning and dies early on bootup. > Will hopefully try to test if/when I have time... :-) > Index: linux-2.6/drivers/ide/pci/hpt366.c > =================================================================== > --- linux-2.6.orig/drivers/ide/pci/hpt366.c > +++ linux-2.6/drivers/ide/pci/hpt366.c > @@ -1,5 +1,5 @@ > /* > - * linux/drivers/ide/pci/hpt366.c Version 1.12 Aug 25, 2007 > + * linux/drivers/ide/pci/hpt366.c Version 1.13 Aug 22, 2007 Errr... and version shuold Aug 02 -- thought I've fixed that. :-/ MBR, Sergei