public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Robert Richter <robert.richter@amd.com>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>,
	Arjan van de Ven <arjan@infradead.org>,
	patches@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [patches] [patch 3/5] x86: Add PCI extended config space access for AMD Barcelona
Date: Wed, 05 Sep 2007 11:12:00 +0100	[thread overview]
Message-ID: <46DE80F0.4000706@zytor.com> (raw)
In-Reply-To: <20070905084427.GE6409@erda.amd.com>

Robert Richter wrote:
> On 05.09.07 06:58:58, H. Peter Anvin wrote:
> 
>>> But at the moment there is no need for further discussion on this subject
>>> because Andi refuses to add support for Barcelona CF8/CFC ECS access.
>>>
>> Well, they don't add any functionality, do they?  As such, I would agree 
>> with Andi -- we only need one method which can (correctly) access the 
>> full configuration space, since it'll look the same on the bus anyway.
> 
> PCI Devices will not be the same on the bus since PCI read/write
> functions will have different behavior. Without the patches you will
> get an error when accessing ECS with CF8. We need ECS access for
> patches that setups local interrupt vectors. This patches will be
> released soon.

You're missing the point.   How will the PCI bus transactions be 
different when using MMCONFIG versus your extended CF8 version?

> Btw, this patch fixes also config space access with proc/sys fs and
> lspci. I see this as an added functionality as well.

The latter implies the former.  Again, how does this differ from MMCONFIG?

	-hpa


  reply	other threads:[~2007-09-05 10:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-03  8:17 [patch 0/5] (resent) x86: PCI extended config space access on AMD Barcelona CPUs Robert Richter
2007-09-03  8:17 ` [patch 1/5] x86: Add AMD64 Barcelona PMU MSR definitions Robert Richter
2007-09-03  8:17 ` [patch 2/5] x86: Add AMD64 Barcelona NB cfg " Robert Richter
2007-09-03  8:17 ` [patch 3/5] x86: Add PCI extended config space access for AMD Barcelona Robert Richter
2007-09-03  8:31   ` Arjan van de Ven
2007-09-03  9:17     ` [patches] " Andreas Herrmann
2007-09-03 11:33       ` Arjan van de Ven
2007-09-03 15:47         ` Andreas Herrmann
2007-09-05  5:58           ` H. Peter Anvin
2007-09-05  8:44             ` Robert Richter
2007-09-05 10:12               ` H. Peter Anvin [this message]
2007-09-05 10:35                 ` Robert Richter
2007-09-05 11:05                 ` Arne Georg Gleditsch
2007-09-05 16:13                   ` Andreas Herrmann
2007-09-05 22:42                     ` Yinghai Lu
2007-09-06  8:31                       ` Arne Georg Gleditsch
2007-09-06  9:48                         ` H. Peter Anvin
2007-09-06 17:41                           ` Jesse Barnes
2007-09-06 17:50                             ` Yinghai Lu
2007-09-06 17:48                               ` Jesse Barnes
2007-09-06 17:48                           ` Yinghai Lu
2007-09-05 15:00             ` Andreas Herrmann
2007-09-06 10:14               ` Arjan van de Ven
2007-09-03  8:17 ` [patch 4/5] x86: Add PCI IDs for AMD Barcelona PCI devices Robert Richter
2007-09-03  8:17 ` [patch 5/5] x86: Set PCI config space size to extended for AMD Barcelona Robert Richter
2007-09-03 16:48   ` dean gaudet
2007-09-03 18:18     ` Robert Richter
2007-09-03 19:01     ` Martin Mares
     [not found] <20070830174311.221133000@amd.com>
     [not found] ` <20070830174311.536394000@amd.com>
2007-09-01 10:11   ` [patch 3/5] x86: Add PCI extended config space access " Andi Kleen
2007-09-03  8:32     ` [patches] " Andreas Herrmann
2007-09-03 10:15       ` Andi Kleen
2007-09-03 11:27         ` Robert Richter
2007-09-03 12:48           ` Andi Kleen
2007-09-03 14:48             ` Robert Richter
2007-09-03 15:24               ` Andi Kleen
2007-09-04  6:54             ` Yinghai Lu
2007-09-04  7:20               ` Andi Kleen
2007-09-03 11:31         ` Andreas Herrmann
2007-09-03 12:52           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DE80F0.4000706@zytor.com \
    --to=hpa@zytor.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox