Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

Bartlomiej Zolnierkiewicz
2007-09-03T18:50:56Z

On Sunday 02 September 2007, Sergei Shtylyov wrote:
> Hello, I wrote:
>
> The patch was 4/4 of course. :-<
> Probably I was too esctatic about the code. ;-)
>
> > The Marvell bridge chips used on HighPoint SATA cards do not seem to support
> > the MWDMA modes (at least that caould be seen in their so-called drivers :-),
> > so the driver needs to account for this -- to achieve this:
>
> > - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz
> > with his consent, also adding the method callout to ide_rate_filter();
>
> > - installed the method for all chips to only return empty mask if a SATA drive
> > is detected onHPT372{AN]/374 chips...
>
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> > ---
> > This patch against the current Linus' tree and unfortunately I was able to only
> > compile test it since that tree gives MODPOST warning and dies early on bootup.
> > Will hopefully try to test if/when I have time... :-)
>
> > Index: linux-2.6/drivers/ide/pci/hpt366.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/ide/pci/hpt366.c
> > +++ linux-2.6/drivers/ide/pci/hpt366.c
> > @@ -1,5 +1,5 @@
> > /*
> > - * linux/drivers/ide/pci/hpt366.c Version 1.12 Aug 25, 2007
> > + * linux/drivers/ide/pci/hpt366.c Version 1.13 Aug 22, 2007
>
> Errr... and version shuold Aug 02 -- thought I've fixed that. :-/

and we have ATA_MWDMA2 define in _vanilla_ kernel now :)

Bart