From: Jeff Garzik <jeff@garzik.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 16/22] advansys: Eliminate prototypes
Date: Sun, 09 Sep 2007 11:29:34 -0400 [thread overview]
Message-ID: <46E4115E.7050203@garzik.org> (raw)
In-Reply-To: <11893498072821-git-send-email-matthew@wil.cx>
Matthew Wilcox wrote:
> Rearrange a lot of the functions in the file to get rid of all the forward
> declarations.
What thoughts, if any, have been given to post-patch code arrangement,
besides eliminating prototypes?
This always struck me as a counterproductive exercise when taken by
itself. Sure, prototypes were eliminated, but was code packed together
in an efficient way afterwards? Ideally hot path code should be close
together, ditto for various other things like error handling code.
Without further explanation or details about your post-patch analysis,
how do we even know the new code arrangement doesn't negatively impact
i-cache overall?
Jeff
next parent reply other threads:[~2007-09-09 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070909145358.GG6809@parisc-linux.org>
[not found] ` <11893498072821-git-send-email-matthew@wil.cx>
2007-09-09 15:29 ` Jeff Garzik [this message]
2007-09-09 17:48 ` [PATCH 16/22] advansys: Eliminate prototypes Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E4115E.7050203@garzik.org \
--to=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox