From: Michael Kerrisk <mtk-manpages@gmx.net>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
corbet@lwn.net, jengelh@computergmbh.de, hch@lst.de,
stable@kernel.org, Ulrich Drepper <drepper@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
tglx@linutronix.de, rdunlap@xenotime.net
Subject: Re: [PATCH] Revised timerfd() interface
Date: Mon, 10 Sep 2007 05:15:29 +0200 [thread overview]
Message-ID: <46E4B6D1.6080909@gmx.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0709061629250.14600@alien.or.mcafeemobile.com>
Hi Davide,
>> This function is *not at all* equivalent to the "get"
>> functionality of the previous APIs. The "get" functionality
>> of POSIX timers (for example) returns a structure that contains
>> the timer interval and the *time until the next expiration of
>> the timer* (not the initial timer string, as your code above
>> does).
>> So come up with a reliable, race-free way of doing that in
>> userspace. Then make it work for both CLOCK_MONOTONIC and
>> CLOCK_REALTIME timers. (You'll certainly need to be making
>> some additional system calls, by the way: at least some
>> calls to clock_gettime().)
>
> No, I don't think I will. Since 1) it's so trivial it's not even
> challenging
Well, it seems to me that the proposed library wrapper code
could start to get rather verbose by the time one adds in
these changes (plus the mutexes).
> 2) you know it can be done (I assume)
Sorry -- I was probably speaking too rhetorically. In fact, it's
not completely clear to me that it can (always) be done. For
example, the answer depends on knowing the clockid. But
what if the file descriptor has been handed off to some code
that doesn't know the clock type (i.e., isn't accessing the fd
via your suggested library)?
Cheers,
Michael
> 3) it solves a non-case
> made up to justify an API/kernel-code bloating.
> But you don't need *my* signoff. Cook a working patch, make a case for it,
> and gather support and signoffs. I won't be acking it because, as I said
> many times, I think it's useless bloating.
next prev parent reply other threads:[~2007-09-10 3:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-25 6:41 [PATCH] Revised timerfd() interface Michael Kerrisk
2007-08-30 12:01 ` Davide Libenzi
2007-09-04 8:03 ` Michael Kerrisk
2007-09-04 8:18 ` Andrew Morton
2007-09-04 8:24 ` Michael Kerrisk
2007-09-04 15:25 ` Davide Libenzi
2007-09-04 15:39 ` Michael Kerrisk
2007-09-04 22:41 ` Davide Libenzi
2007-09-04 20:49 ` Michael Kerrisk
2007-09-04 22:44 ` Davide Libenzi
2007-09-05 0:08 ` Michael Kerrisk
2007-09-05 12:02 ` Andrew Morton
2007-09-05 16:14 ` Davide Libenzi
2007-09-05 16:23 ` Michael Kerrisk
2007-09-05 19:57 ` Davide Libenzi
2007-09-05 22:50 ` Michael Kerrisk
2007-09-05 23:45 ` Davide Libenzi
2007-09-06 6:58 ` Michael Kerrisk
2007-09-06 23:37 ` Davide Libenzi
2007-09-10 3:15 ` Michael Kerrisk [this message]
2007-09-05 12:12 ` Denys Vlasenko
2007-09-05 15:32 ` timerfd redux Michael Kerrisk
2007-09-13 2:39 ` Andrew Morton
2007-09-13 6:14 ` Michael Kerrisk
2007-09-13 8:13 ` Michael Kerrisk
2007-09-13 8:20 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2007-07-23 6:32 Problems with timerfd() Michael Kerrisk
2007-07-23 6:38 ` Andrew Morton
2007-07-25 18:18 ` Michael Kerrisk
2007-07-25 22:12 ` Andrew Morton
2007-08-07 6:55 ` Michael Kerrisk
2007-08-09 21:11 ` [PATCH] Revised timerfd() interface Michael Kerrisk
2007-08-13 23:34 ` Randy Dunlap
2007-08-15 14:40 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E4B6D1.6080909@gmx.net \
--to=mtk-manpages@gmx.net \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=hch@lst.de \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).