Re: [RESEND][PATCH 1/4] Introduce a new field "guest" in cpustat

[Laurent Vivier <Laurent.Vivier@bull.net>]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

Rik van Riel wrote:
> Laurent Vivier wrote:
>> [PATCH 1/4] as recent CPUs introduce a third running state, after
>> "user" and
>> "system", we need a new field, "guest", in cpustat to store the time
>> used by
>> the CPU to run virtual CPU. Modify /proc/stat to display this new field.
> 
> I think it would be good to always print out that number, even if
> it is zero without the CONFIG option set.
> 
> Changing the format of /proc/stat depending on config options is
> probably worse than changing it when moving kernel versions.
> 
> I guess reusing the "steal" field is not a good idea, since your
> new "guest time" has different semantics than the steal time field.
> 

I agree with all.

Laurent
-- 
------------- Laurent.Vivier@bull.net  --------------
          "Software is hard" - Donald Knuth


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]