Re: [RFC+PATCH] RTC calibration

Clemens Koller
2007-09-11T15:37:03Z

Dag-Erling Smørgrav schrieb:
> Clemens Koller <clemens.koller@anagramm.de> writes:
>> It looks odd to me to do only differential up and down adjustments.
>> I would prefer read_calibration_register and write_calibration_register
>> access and let the userspace decide how much it wants to
>> increment/decrement the register.
>
> Without knowing exacly which chip is present, there is no way for the
> userland calibration tool to know how big a difference a calibration
> step makes.

I am not talking about the calibration algorithm and it's quality.
I am talking about _how_ the calibration register is addressed from
userspace. It's a simple register, some bits at address 7 and I would
expect to read/modify/write registers to do all the things you want
to do. Register access in userspace doesn't put any limitation
to applications.
Having only incs and decs without getting the actual value back seems
to be an absolutely unnecessary limitation here.
You cannot get the current value back to see if it's i.e. in saturation in
a way that it doesn't make sense to inc/decrement it further or in bigger steps
or reset it to zero...

Regards,

Clemens Koller
__________________________________
R&D Imaging Devices
Anagramm GmbH
Rupert-Mayer-Straße 45/1
Linhof Werksgelände
D-81379 München
Tel.089-741518-50
Fax 089-741518-19