From: Rene Herman <rene.herman@gmail.com>
To: Adrian McMenamin <lkmladrian@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxsh-dev@lists.sourceforge.net,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: time_after - what on earth???
Date: Wed, 12 Sep 2007 00:19:09 +0200 [thread overview]
Message-ID: <46E7145D.10907@gmail.com> (raw)
In-Reply-To: <8b67d60709111515m5b45c57emef5cc2f74795ed7a@mail.gmail.com>
On 09/12/2007 12:15 AM, Adrian McMenamin wrote:
> On 11/09/2007, Rene Herman <rene.herman@gmail.com> wrote:
>> On 09/12/2007 12:05 AM, Adrian McMenamin wrote:
>>
>>> OK, why does this line occasionally return true:
>>>
>>> if ((maple_dev->interval > 0) && (jiffies >maple_dev->when))
>>>
>>> while this one never does (no other changes made):
>>>
>>> if ((maple_dev->interval > 0) && (time_after(jiffies, maple_dev->when)))
>> Is maple_dev->when an unsigned long?
>>
> Yes. Does that make a difference?
If it had been a signed type, it could've wrapped to something you didn't
expect, explaining the difference at least...
With an unsigned long, the only diference should be that time_after() deals
with jiffie wrapping which I assume is not an actual problem here. I'll
retreat into the shades again... ;-(
Rene.
next prev parent reply other threads:[~2007-09-11 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 22:05 time_after - what on earth??? Adrian McMenamin
2007-09-11 22:11 ` Rene Herman
2007-09-11 22:15 ` Adrian McMenamin
2007-09-11 22:19 ` Rene Herman [this message]
2007-09-11 23:09 ` Björn Steinbrink
2007-09-11 23:10 ` Adrian McMenamin
2007-09-11 23:50 ` Björn Steinbrink
2007-09-12 0:03 ` Adrian McMenamin
2007-09-11 23:16 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E7145D.10907@gmail.com \
--to=rene.herman@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxsh-dev@lists.sourceforge.net \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox