* 2.6.23-rc4-mm1: kgdboe link errors
@ 2007-09-12 9:31 Jiri Slaby
2007-09-12 17:15 ` [PATCH -mm] " Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Slaby @ 2007-09-12 9:31 UTC (permalink / raw)
To: Andrew Morton
Cc: Matt Mackall, jason.wessel, amitkale, kgdb-bugreport,
Linux kernel mailing list
Hi,
randconfig [1] causes this link errors:
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [all] Error 2
[1] http://www.fi.muni.cz/~xslaby/sklad/1.config
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors
2007-09-12 9:31 2.6.23-rc4-mm1: kgdboe link errors Jiri Slaby
@ 2007-09-12 17:15 ` Randy Dunlap
2007-09-12 18:15 ` Matt Mackall
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2007-09-12 17:15 UTC (permalink / raw)
To: Jiri Slaby
Cc: Andrew Morton, kgdb-bugreport, amitkale, jason.wessel,
Linux kernel mailing list, Matt Mackall
On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote:
> randconfig [1] causes this link errors:
> ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [all] Error 2
>
> [1] http://www.fi.muni.cz/~xslaby/sklad/1.config
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
make[1]: *** [__modpost] Error 1
Add 'select' for net-poll/console related config symbols, but
make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET,
but if it is already enabled, the 'select's will enable the rest
of the needed interfaces.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
lib/Kconfig.kgdb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
+++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
@@ -174,9 +174,11 @@ endchoice
config KGDBOE
tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
- depends on m && KGDB
+ depends on m && KGDB && NET
+ select NETCONSOLE
select NETPOLL
select NETPOLL_TRAP
+ select NET_POLL_CONTROLLER
help
Uses the NETPOLL API to communicate with the host GDB via UDP.
In order for this to work, the ethernet interface specified must
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors
2007-09-12 17:15 ` [PATCH -mm] " Randy Dunlap
@ 2007-09-12 18:15 ` Matt Mackall
2007-09-12 18:22 ` [PATCH -mm v2] " Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Matt Mackall @ 2007-09-12 18:15 UTC (permalink / raw)
To: Randy Dunlap
Cc: Jiri Slaby, Andrew Morton, kgdb-bugreport, amitkale, jason.wessel,
Linux kernel mailing list
On Wed, Sep 12, 2007 at 10:15:37AM -0700, Randy Dunlap wrote:
> On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote:
>
> > randconfig [1] causes this link errors:
> > ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
> > ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
> > ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
> > ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
> > ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
> > ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
> > make[2]: *** [__modpost] Error 1
> > make[1]: *** [modules] Error 2
> > make: *** [all] Error 2
> >
> > [1] http://www.fi.muni.cz/~xslaby/sklad/1.config
>
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kgdb build problems:
> Building modules, stage 2.
> ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
>
> Add 'select' for net-poll/console related config symbols, but
> make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET,
> but if it is already enabled, the 'select's will enable the rest
> of the needed interfaces.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> lib/Kconfig.kgdb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
> +++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
> @@ -174,9 +174,11 @@ endchoice
>
> config KGDBOE
> tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
> - depends on m && KGDB
> + depends on m && KGDB && NET
> + select NETCONSOLE
NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
kconfig-addled brain.
> select NETPOLL
> select NETPOLL_TRAP
> + select NET_POLL_CONTROLLER
> help
> Uses the NETPOLL API to communicate with the host GDB via UDP.
> In order for this to work, the ethernet interface specified must
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors
2007-09-12 18:15 ` Matt Mackall
@ 2007-09-12 18:22 ` Randy Dunlap
2007-09-12 18:50 ` Matt Mackall
2007-09-12 19:17 ` [Kgdb-bugreport] " Jason Wessel
0 siblings, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2007-09-12 18:22 UTC (permalink / raw)
To: Matt Mackall
Cc: Jiri Slaby, kgdb-bugreport, amitkale, Linux kernel mailing list,
jason.wessel, Andrew Morton
On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
> NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
> kconfig-addled brain.
Correct. Patch corrected. Thanks.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
make[1]: *** [__modpost] Error 1
Add 'select' for net-poll related config symbols, but
make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET,
but if it is already enabled, the 'select's will enable the rest
of the needed interfaces.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
lib/Kconfig.kgdb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
+++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
@@ -174,9 +174,10 @@ endchoice
config KGDBOE
tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
- depends on m && KGDB
+ depends on m && KGDB && NET
select NETPOLL
select NETPOLL_TRAP
+ select NET_POLL_CONTROLLER
help
Uses the NETPOLL API to communicate with the host GDB via UDP.
In order for this to work, the ethernet interface specified must
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors
2007-09-12 18:22 ` [PATCH -mm v2] " Randy Dunlap
@ 2007-09-12 18:50 ` Matt Mackall
2007-09-12 19:17 ` [Kgdb-bugreport] " Jason Wessel
1 sibling, 0 replies; 6+ messages in thread
From: Matt Mackall @ 2007-09-12 18:50 UTC (permalink / raw)
To: Randy Dunlap
Cc: Jiri Slaby, kgdb-bugreport, amitkale, Linux kernel mailing list,
jason.wessel, Andrew Morton
On Wed, Sep 12, 2007 at 11:22:52AM -0700, Randy Dunlap wrote:
> On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
>
> > NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
> > kconfig-addled brain.
>
> Correct. Patch corrected. Thanks.
Looks good to me, but I'll leave the actual ack to the KGDB guys.
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Kgdb-bugreport] [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors
2007-09-12 18:22 ` [PATCH -mm v2] " Randy Dunlap
2007-09-12 18:50 ` Matt Mackall
@ 2007-09-12 19:17 ` Jason Wessel
1 sibling, 0 replies; 6+ messages in thread
From: Jason Wessel @ 2007-09-12 19:17 UTC (permalink / raw)
To: Randy Dunlap
Cc: Matt Mackall, Jiri Slaby, kgdb-bugreport, amitkale,
Linux kernel mailing list, Andrew Morton
Randy,
This patch is fine, and I am committing it to the for_mm kgdb tree.
I am also adding the "depends on NET" to the KGDBOE_NOMODULE section,
which would otherwise to a select on KGDBOE. We have to cover the case
for KGDB as a module and not as a module.
Thanks,
Jason.
Randy Dunlap wrote:
> On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
>
>
>> NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
>> kconfig-addled brain.
>>
>
> Correct. Patch corrected. Thanks.
>
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kgdb build problems:
> Building modules, stage 2.
> ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
>
> Add 'select' for net-poll related config symbols, but
> make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET,
> but if it is already enabled, the 'select's will enable the rest
> of the needed interfaces.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> lib/Kconfig.kgdb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
> +++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
> @@ -174,9 +174,10 @@ endchoice
>
> config KGDBOE
> tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
> - depends on m && KGDB
> + depends on m && KGDB && NET
> select NETPOLL
> select NETPOLL_TRAP
> + select NET_POLL_CONTROLLER
> help
> Uses the NETPOLL API to communicate with the host GDB via UDP.
> In order for this to work, the ethernet interface specified must
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Kgdb-bugreport mailing list
> Kgdb-bugreport@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-09-12 19:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-12 9:31 2.6.23-rc4-mm1: kgdboe link errors Jiri Slaby
2007-09-12 17:15 ` [PATCH -mm] " Randy Dunlap
2007-09-12 18:15 ` Matt Mackall
2007-09-12 18:22 ` [PATCH -mm v2] " Randy Dunlap
2007-09-12 18:50 ` Matt Mackall
2007-09-12 19:17 ` [Kgdb-bugreport] " Jason Wessel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox