* [PATCH 4/5][AFS] Use macro instead of explicit check for mandatory locks
@ 2007-09-12 11:27 Pavel Emelyanov
0 siblings, 0 replies; only message in thread
From: Pavel Emelyanov @ 2007-09-12 11:27 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Mailing List, devel
The __MANDATORY_LOCK(inode) macro makes the same check, but
makes the code more readable.
Unfortunately, I haven't found the maintainer for this FS in
the MAINTAINERS file.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
fs/afs/flock.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/afs/flock.c b/fs/afs/flock.c
index af6952e..9ddac05 100644
--- a/fs/afs/flock.c
+++ b/fs/afs/flock.c
@@ -524,8 +524,7 @@ int afs_lock(struct file *file, int cmd,
(long long) fl->fl_start, (long long) fl->fl_end);
/* AFS doesn't support mandatory locks */
- if ((vnode->vfs_inode.i_mode & (S_ISGID | S_IXGRP)) == S_ISGID &&
- fl->fl_type != F_UNLCK)
+ if (__MANDATORY_LOCK(vnode->vfs_inode) && fl->fl_type != F_UNLCK)
return -ENOLCK;
if (IS_GETLK(cmd))
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-09-12 11:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-12 11:27 [PATCH 4/5][AFS] Use macro instead of explicit check for mandatory locks Pavel Emelyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox