public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Brent Casavant <bcasavan@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: O_NOLINK for open()
Date: Wed, 12 Sep 2007 14:46:41 -0700	[thread overview]
Message-ID: <46E85E41.5000403@zytor.com> (raw)
In-Reply-To: <20070912163645.E5573@pkunk.americas.sgi.com>

Brent Casavant wrote:
> On Wed, 12 Sep 2007, H. Peter Anvin wrote:
> 
>> Brent Casavant wrote:
> 
>>> 	http://marc.info/?l=linux-kernel&m=93032806224160&w=2
>> This link talks about file flags handling.  I don't see the relevance to
>> this problem at all.  However, this is a very long thread, so if there
>> is anything specific that you want to point to, then please elucidate.
> 
> Oops, my mistake -- I pasted the wrong URL.  I meant this thread, this
> post in particular:
> 
> 	http://marc.info/?l=linux-kernel&m=88937224115435&w=2
> 
> Still, O_NOLINK would seem to be a valuable addition, and greatly
> simplify secure temporary file creation.
> 

Avoiding -- or at least detecting -- symlink racing with mkdir() is
relatively simple: run mkdir(), make sure you don't get EEXIST or
something like that, lstat() the resulting path -- it should be a
directory with all the right modes and ownerships.

I believe -- but I'm not certain -- that mkdtemp() in glibc will do all
this for you.  If not, I would consider that a glibc bug.

	-hpa

  reply	other threads:[~2007-09-12 21:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 20:37 O_NOLINK for open() Brent Casavant
2007-09-12 21:07 ` H. Peter Anvin
2007-09-12 21:39   ` Brent Casavant
2007-09-12 21:46     ` H. Peter Anvin [this message]
2007-09-12 21:42 ` Andreas Schwab
2007-09-12 22:44   ` Brent Casavant
2007-09-12 22:49     ` Al Viro
2007-09-12 23:27       ` Brent Casavant
2007-09-12 23:48         ` Brent Casavant
2007-09-14 16:37         ` Goswin von Brederlow
2007-09-13 10:08 ` Gabor Gombas
2007-09-13 16:05   ` Brent Casavant
     [not found] <92Haf-7z7-5@gated-at.bofh.it>
2007-09-12 22:33 ` Bodo Eggert
2007-09-13  9:13   ` Jan Kara
2007-09-14  9:07     ` Bodo Eggert
     [not found] ` <92TO5-246-1@gated-at.bofh.it>
     [not found]   ` <92Zqu-2ur-1@gated-at.bofh.it>
2007-09-14 10:30     ` Bodo Eggert
2007-09-14 10:50       ` Andreas Schwab
2007-09-14 17:26         ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E85E41.5000403@zytor.com \
    --to=hpa@zytor.com \
    --cc=bcasavan@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox