From: Jeff Garzik <jeff@garzik.org>
To: Kees Cook <kees@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, Ben Collins <bcollins@ubuntu.com>
Subject: Re: [PATCH] usb: fix unterminated usn_device_id lists
Date: Wed, 12 Sep 2007 21:15:07 -0400 [thread overview]
Message-ID: <46E88F1B.5050405@garzik.org> (raw)
In-Reply-To: <20070913004709.GL8183@outflux.net>
Kees Cook wrote:
> This patch against 2.6.23-rc6 fixes a unterminated list of USB device ids.
>
> Signed-off-by: Kees Cook <kees@ubuntu.com>
> ---
> linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c | 1 +
> 1 file changed, 1 insertion(+)
> ---
> diff -urp -x '*.o' linux-2.6.23-rc6~/drivers/media/video/usbvision/usbvision-cards.c linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c
> --- linux-2.6.23-rc6~/drivers/media/video/usbvision/usbvision-cards.c 2007-09-11 23:17:19.000000000 -0700
> +++ linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c 2007-09-12 17:26:46.000000000 -0700
> @@ -1081,6 +1081,7 @@ struct usb_device_id usbvision_table []
> { USB_DEVICE(0x2304, 0x0301), .driver_info=PINNA_LINX_VD_IN_CAB_PAL },
> { USB_DEVICE(0x2304, 0x0419), .driver_info=PINNA_PCTV_BUNGEE_PAL_FM },
> { USB_DEVICE(0x2400, 0x4200), .driver_info=HPG_WINTV },
> + { 0, },
FWIW I (and several drivers) tend to prefer the more clean version,
{ },
or even
{ }, /* terminate list */
Regards,
Jeff
next prev parent reply other threads:[~2007-09-13 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 0:47 [PATCH] usb: fix unterminated usn_device_id lists Kees Cook
2007-09-13 1:15 ` Jeff Garzik [this message]
2007-09-13 3:54 ` Kees Cook
2007-09-13 4:02 ` Jeff Garzik
2007-09-13 4:45 ` [PATCHv2] misc: fix unterminated *_device_id lists Kees Cook
2007-09-13 5:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E88F1B.5050405@garzik.org \
--to=jeff@garzik.org \
--cc=bcollins@ubuntu.com \
--cc=kees@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox