From: Jeff Garzik <jeff@garzik.org>
To: Kees Cook <kees@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, Ben Collins <bcollins@ubuntu.com>
Subject: Re: [PATCH] usb: fix unterminated usn_device_id lists
Date: Thu, 13 Sep 2007 00:02:21 -0400 [thread overview]
Message-ID: <46E8B64D.3030107@garzik.org> (raw)
In-Reply-To: <20070913035407.GN8183@outflux.net>
Kees Cook wrote:
> Hi,
>
> On Wed, Sep 12, 2007 at 09:15:07PM -0400, Jeff Garzik wrote:
>>> + { 0, },
>> FWIW I (and several drivers) tend to prefer the more clean version,
>>
>> { },
>>
>> or even
>>
>> { }, /* terminate list */
>
> Ah, yes. I see that now in some of the other drivers. Should I re-send
> this patch (and/or the other PCI patches)?
Can't hurt... but I cannot speak for other maintainers.
Jeff
next prev parent reply other threads:[~2007-09-13 4:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 0:47 [PATCH] usb: fix unterminated usn_device_id lists Kees Cook
2007-09-13 1:15 ` Jeff Garzik
2007-09-13 3:54 ` Kees Cook
2007-09-13 4:02 ` Jeff Garzik [this message]
2007-09-13 4:45 ` [PATCHv2] misc: fix unterminated *_device_id lists Kees Cook
2007-09-13 5:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E8B64D.3030107@garzik.org \
--to=jeff@garzik.org \
--cc=bcollins@ubuntu.com \
--cc=kees@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox