* Re: [patch] Fix BIOS-e820 end address
2007-09-08 20:50 [patch] Fix BIOS-e820 end address Keshavamurthy, Anil S
@ 2007-09-08 7:05 ` Jan Engelhardt
2007-09-14 21:00 ` Jeremy Fitzhardinge
1 sibling, 0 replies; 5+ messages in thread
From: Jan Engelhardt @ 2007-09-08 7:05 UTC (permalink / raw)
To: Keshavamurthy, Anil S; +Cc: akpm, Linux Kernel, suresh.b.siddha
On Sep 8 2007 13:50, Keshavamurthy, Anil S wrote:
>--snip of boot message--
>BIOS-provided physical RAM map:
> BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
> BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
> BIOS-e820: 0000000000100000 - 000000007fe8cc00 (usable)
>----end snip---
>
>As you see from above the address 0000000000100000 is both
>shown as reserved and usable which is confusing.
>
>This patch fixes the BIOS-e820 end address.
If a segment should have size 0 (even possible?), your
patch makes it even more confusing.
Jan
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch] Fix BIOS-e820 end address
@ 2007-09-08 20:50 Keshavamurthy, Anil S
2007-09-08 7:05 ` Jan Engelhardt
2007-09-14 21:00 ` Jeremy Fitzhardinge
0 siblings, 2 replies; 5+ messages in thread
From: Keshavamurthy, Anil S @ 2007-09-08 20:50 UTC (permalink / raw)
To: akpm, Linux Kernel; +Cc: suresh.b.siddha
Subject: [patch] Fix BIOS-e820 end address
--snip of boot message--
BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
BIOS-e820: 0000000000100000 - 000000007fe8cc00 (usable)
----end snip---
As you see from above the address 0000000000100000 is both
shown as reserved and usable which is confusing.
This patch fixes the BIOS-e820 end address.
Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
---
arch/i386/kernel/e820.c | 2 +-
arch/x86_64/kernel/e820.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Index: work/arch/i386/kernel/e820.c
===================================================================
--- work.orig/arch/i386/kernel/e820.c 2007-09-08 12:00:33.000000000 -0700
+++ work/arch/i386/kernel/e820.c 2007-09-08 13:39:12.000000000 -0700
@@ -753,7 +753,7 @@
for (i = 0; i < e820.nr_map; i++) {
printk(" %s: %016Lx - %016Lx ", who,
e820.map[i].addr,
- e820.map[i].addr + e820.map[i].size);
+ e820.map[i].addr + e820.map[i].size - 1);
switch (e820.map[i].type) {
case E820_RAM: printk("(usable)\n");
break;
Index: work/arch/x86_64/kernel/e820.c
===================================================================
--- work.orig/arch/x86_64/kernel/e820.c 2007-09-08 12:00:46.000000000 -0700
+++ work/arch/x86_64/kernel/e820.c 2007-09-08 13:38:57.000000000 -0700
@@ -368,7 +368,7 @@
for (i = 0; i < e820.nr_map; i++) {
printk(KERN_INFO " %s: %016Lx - %016Lx ", who,
(unsigned long long) e820.map[i].addr,
- (unsigned long long) (e820.map[i].addr + e820.map[i].size));
+ (unsigned long long) (e820.map[i].addr + e820.map[i].size - 1));
switch (e820.map[i].type) {
case E820_RAM: printk("(usable)\n");
break;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Fix BIOS-e820 end address
2007-09-08 20:50 [patch] Fix BIOS-e820 end address Keshavamurthy, Anil S
2007-09-08 7:05 ` Jan Engelhardt
@ 2007-09-14 21:00 ` Jeremy Fitzhardinge
2007-09-14 21:31 ` Siddha, Suresh B
1 sibling, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2007-09-14 21:00 UTC (permalink / raw)
To: Keshavamurthy, Anil S; +Cc: akpm, Linux Kernel, suresh.b.siddha
Keshavamurthy, Anil S wrote:
> Subject: [patch] Fix BIOS-e820 end address
>
> --snip of boot message--
> BIOS-provided physical RAM map:
> BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
> BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
> BIOS-e820: 0000000000100000 - 000000007fe8cc00 (usable)
> ----end snip---
>
> As you see from above the address 0000000000100000 is both
> shown as reserved and usable which is confusing.
>
I think this is consistent with many other kernel interfaces (such as
/proc/X/maps) where the end address is taken to be exclusive: [0xf0000,
0x100000).
J
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Fix BIOS-e820 end address
2007-09-14 21:31 ` Siddha, Suresh B
@ 2007-09-14 21:31 ` Keshavamurthy, Anil S
0 siblings, 0 replies; 5+ messages in thread
From: Keshavamurthy, Anil S @ 2007-09-14 21:31 UTC (permalink / raw)
To: Siddha, Suresh B
Cc: Jeremy Fitzhardinge, Keshavamurthy, Anil S, akpm, Linux Kernel,
ak
On Fri, Sep 14, 2007 at 02:31:59PM -0700, Siddha, Suresh B wrote:
> On Fri, Sep 14, 2007 at 02:00:02PM -0700, Jeremy Fitzhardinge wrote:
> > Keshavamurthy, Anil S wrote:
> > > Subject: [patch] Fix BIOS-e820 end address
> > >
> > > --snip of boot message--
> > > BIOS-provided physical RAM map:
> > > BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
> > > BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
> > > BIOS-e820: 0000000000100000 - 000000007fe8cc00 (usable)
> > > ----end snip---
> > >
> > > As you see from above the address 0000000000100000 is both
> > > shown as reserved and usable which is confusing.
> > >
> >
> > I think this is consistent with many other kernel interfaces (such as
> > /proc/X/maps) where the end address is taken to be exclusive: [0xf0000,
> > 0x100000).
>
> Andrew, Please disregard this patch. As Jermy, Jan pointed out, this
> will cause more confusions. Thanks.
I agree, we can discard my patch.
-Anil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Fix BIOS-e820 end address
2007-09-14 21:00 ` Jeremy Fitzhardinge
@ 2007-09-14 21:31 ` Siddha, Suresh B
2007-09-14 21:31 ` Keshavamurthy, Anil S
0 siblings, 1 reply; 5+ messages in thread
From: Siddha, Suresh B @ 2007-09-14 21:31 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Keshavamurthy, Anil S, akpm, Linux Kernel, suresh.b.siddha
On Fri, Sep 14, 2007 at 02:00:02PM -0700, Jeremy Fitzhardinge wrote:
> Keshavamurthy, Anil S wrote:
> > Subject: [patch] Fix BIOS-e820 end address
> >
> > --snip of boot message--
> > BIOS-provided physical RAM map:
> > BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
> > BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
> > BIOS-e820: 0000000000100000 - 000000007fe8cc00 (usable)
> > ----end snip---
> >
> > As you see from above the address 0000000000100000 is both
> > shown as reserved and usable which is confusing.
> >
>
> I think this is consistent with many other kernel interfaces (such as
> /proc/X/maps) where the end address is taken to be exclusive: [0xf0000,
> 0x100000).
Andrew, Please disregard this patch. As Jermy, Jan pointed out, this
will cause more confusions. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-14 21:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-08 20:50 [patch] Fix BIOS-e820 end address Keshavamurthy, Anil S
2007-09-08 7:05 ` Jan Engelhardt
2007-09-14 21:00 ` Jeremy Fitzhardinge
2007-09-14 21:31 ` Siddha, Suresh B
2007-09-14 21:31 ` Keshavamurthy, Anil S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox