From: Eric Valette <eric.valette@free.fr>
To: "\"Paul Rolland (ポール・ロラン)\"" <rol@witbe.net>
Cc: Rob Hussey <robjhussey@gmail.com>,
flamingice@sourmilk.net, andreamrl@tiscali.it,
linux-kernel@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module.
Date: Sat, 15 Sep 2007 21:00:11 +0200 [thread overview]
Message-ID: <46EC2BBB.1030506@free.fr> (raw)
In-Reply-To: <20070915185153.08490a9b@tux.DEF.witbe.net>
Paul Rolland (ポール・ロラン) wrote:
> Hi Eric,
>> Now I have two side questions:
>> - the code is no more symetric "subsys_initcall" -> "module_exit".
>> Do not know if it is "normal" but I love symmetry in code :-). Did not test
>> it still works as a module...
> Symmetry is not broken, as we have :
> #define subsys_initcall(fn) module_init(fn)
> in include/linux/init.h where compiling as a module, and when not compiling
> as a module, I doubt the exit function is called unless you are shuting
> down your machine...
I came to this conclusion too. But I would have preferred to have
#define subsys_exit(fn) modules_exit(fn)
in the case of a module and nop in the non module case...
-- eric
next prev parent reply other threads:[~2007-09-15 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 14:07 rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module Eric Valette
2007-09-15 14:27 ` Eric Valette
2007-09-15 15:38 ` Paul Rolland
2007-09-15 16:28 ` Rob Hussey
2007-09-15 17:41 ` Paul Rolland
2007-09-15 18:30 ` Eric Valette
2007-09-15 18:51 ` Paul Rolland
2007-09-15 19:00 ` Eric Valette [this message]
2007-09-17 9:48 ` Johannes Berg
2007-09-17 11:44 ` Eric Valette
2007-09-15 21:19 ` Rob Hussey
2007-09-25 8:05 ` Eric Valette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EC2BBB.1030506@free.fr \
--to=eric.valette@free.fr \
--cc=andreamrl@tiscali.it \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=robjhussey@gmail.com \
--cc=rol@witbe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox