Re: [PATCH]PCI:disable resource decode in PCI BAR detection

[Robert Hancock <hancockr@shaw.ca>]

Benjamin Herrenschmidt wrote:
> On Thu, 2007-09-13 at 21:32 -0600, Robert Hancock wrote:
>> If we do encounter other devices that choke on having the BAR
>> disabled 
>> during probing then we can add additional quirk logic, but we haven't 
>> run into anything like that yet.
> 
> Well... if the device needs to be accessed to service an interrupt then
> you do have a problem. For example... the PIC :-)
> 
> Problem is.. it's not practical nor really feasible generally to have
> IRQs off on all CPUs during PCI probing neither... Unless we define that
> the initial boot time probing is "special", and the first pass that
> actually probes devices (and doesn't muck around with the sysfs
> hierarchy etc...) can be run in a special context with all interrupt
> servicing disabled on the PIC, though that will require some arch
> support.
> 
> Ben.

We would already have this problem, though. If it causes problems to 
disable decode on the BAR because we try to access it in interrupt 
context, we would already have problems because we move the thing to 
0xFFFFFFFF during probing anyway..

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/