* [PATCH 3/5][9PFS] Cleanup explicit check for mandatory locks
@ 2007-09-17 7:53 Pavel Emelyanov
2007-09-17 14:51 ` Eric Van Hensbergen
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-09-17 7:53 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Kernel Mailing List, devel, Eric Van Hensbergen,
Ron Minnich, Latchesar Ionkov
The __mandatory_lock(inode) macro makes the same check, but
makes the code more readable.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
---
fs/9p/vfs_file.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 2a40c29..7166916 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -105,7 +105,7 @@ static int v9fs_file_lock(struct file *f
P9_DPRINTK(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl);
/* No mandatory locks */
- if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
+ if (__mandatory_lock(inode))
return -ENOLCK;
if ((IS_SETLK(cmd) || IS_SETLKW(cmd)) && fl->fl_type != F_UNLCK) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3/5][9PFS] Cleanup explicit check for mandatory locks
2007-09-17 7:53 [PATCH 3/5][9PFS] Cleanup explicit check for mandatory locks Pavel Emelyanov
@ 2007-09-17 14:51 ` Eric Van Hensbergen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Van Hensbergen @ 2007-09-17 14:51 UTC (permalink / raw)
To: Pavel Emelyanov
Cc: Andrew Morton, Linux Kernel Mailing List, devel, Ron Minnich,
Latchesar Ionkov
On 9/17/07, Pavel Emelyanov <xemul@openvz.org> wrote:
> The __mandatory_lock(inode) macro makes the same check, but
> makes the code more readable.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Acked-by: Eric Van Hensbergen <ericvh@gmail.com>
>
> ---
>
> fs/9p/vfs_file.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 2a40c29..7166916 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -105,7 +105,7 @@ static int v9fs_file_lock(struct file *f
> P9_DPRINTK(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl);
>
> /* No mandatory locks */
> - if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
> + if (__mandatory_lock(inode))
> return -ENOLCK;
>
> if ((IS_SETLK(cmd) || IS_SETLKW(cmd)) && fl->fl_type != F_UNLCK) {
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-17 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-17 7:53 [PATCH 3/5][9PFS] Cleanup explicit check for mandatory locks Pavel Emelyanov
2007-09-17 14:51 ` Eric Van Hensbergen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox