public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: EDD still failing on some systems with 2.6.23-rc6-git2
Date: Mon, 17 Sep 2007 08:32:24 -0700	[thread overview]
Message-ID: <46EE9E08.60604@zytor.com> (raw)
In-Reply-To: <46EE99C0.5020106@redhat.com>

Chuck Ebbert wrote:
> 
> Still fails. And apparently fails on disk 0, because it hangs right
> after printing a zero:
> 
> --- linux-2.6.22.noarch.orig/arch/i386/boot/edd.c
> +++ linux-2.6.22.noarch/arch/i386/boot/edd.c
> @@ -151,6 +151,7 @@ void query_edd(void)
>                  * Scan the BIOS-supported hard disks and query EDD
>                  * information...
>                  */
> +               putchar('0' + (devno - 0x80) % 10);
>                 get_edd_info(devno, &ei);
> 
>                 if (boot_params.eddbuf_entries < EDDMAXNR) {

You know... we actually do have printf()... you don't have to play this
kind of games; you can just printf("Drive %x...\n", devno);

So does this happen ONLY when booting from CD-ROM, or is there any other
case when it fails, too?

	-hpa

      reply	other threads:[~2007-09-17 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-14 15:32 EDD still failing on some systems with 2.6.23-rc6-git2 Chuck Ebbert
2007-09-14 16:06 ` H. Peter Anvin
2007-09-17 15:14   ` Chuck Ebbert
2007-09-17 15:32     ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46EE9E08.60604@zytor.com \
    --to=hpa@zytor.com \
    --cc=cebbert@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox