From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-kernel@vger.kernel.org,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: 2.6.23-rc4-mm1 compile error for ppc 32
Date: Tue, 18 Sep 2007 02:14:27 +0530 [thread overview]
Message-ID: <46EEE72B.1010008@linux.vnet.ibm.com> (raw)
In-Reply-To: <1190061073.6403.66.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Sat, 2007-09-15 at 11:00 -0400, Mathieu Desnoyers wrote:
>> * Benjamin Herrenschmidt (benh@kernel.crashing.org) wrote:
>>> On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote:
>>>
>>>> Like this?
>>>>
>>>> --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix
>>>> +++ a/include/asm-powerpc/bitops.h
>>>> @@ -226,7 +226,7 @@ static __inline__ void set_bits(unsigned
>>>>
>>>> static __inline__ void __clear_bit_unlock(int nr, volatile unsigned long *addr)
>>>> {
>>>> - __asm__ __volatile__(LWSYNC_ON_SMP ::: "memory");
>>>> + __asm__ __volatile__(LWSYNC_ON_SMP "" ::: "memory");
>>>> __clear_bit(nr, addr);
>>>> }
>>>>
>>> Looks ok. Can somebody test ? I'm still travelling...
>>>
>>>
>> Hi Benjamin,
>>
>> With this patch and hrtimer.c fixes, 2.6.23-rc4-mm1 PPC arch (for
>> powerpc 405) compiles fine.
>>
>> I still see errors/warnings from modpost though:
>
> Looks like the legacy ISA DMA crap no ? I don't know much about it.
>
> Ben.
>
Kamalesh has reported a similar bug and is looking to fix this problem.
He's been looking at Kconfig's to see that all of them either
depend on GENERIC_ISA_DMA or select it.
>> make -f /home/compudj/git/linux-2.6-lttng/scripts/Makefile.modpost
>> scripts/mod/modpost -m -o /home/compudj/obj/powerpc-405/Module.symvers -s
>> ERROR: "request_dma" [sound/oss/sscape.ko] undefined!
>> ERROR: "free_dma" [sound/oss/sscape.ko] undefined!
>> ERROR: "dma_spin_lock" [sound/oss/sscape.ko] undefined!
>> ERROR: "free_dma" [sound/oss/sound.ko] undefined!
>> ERROR: "request_dma" [sound/oss/sound.ko] undefined!
>> ERROR: "dma_spin_lock" [sound/oss/sound.ko] undefined!
>> ERROR: "dma_spin_lock" [sound/core/snd.ko] undefined!
>> ERROR: "dma_spin_lock" [net/irda/irda.ko] undefined!
>> WARNING: "div64_64" [net/ipv4/tcp_cubic.ko] has no CRC!
>> ERROR: "free_dma" [drivers/parport/parport_pc.ko] undefined!
>> ERROR: "request_dma" [drivers/parport/parport_pc.ko] undefined!
>> ERROR: "dma_spin_lock" [drivers/parport/parport_pc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/w83977af_ir.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/w83977af_ir.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/via-ircc.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/via-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/smsc-ircc2.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/smsc-ircc2.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/nsc-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/nsc-ircc.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/ali-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/ali-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/mmc/host/wbsd.ko] undefined!
>> ERROR: "dma_spin_lock" [drivers/mmc/host/wbsd.ko] undefined!
>> ERROR: "free_dma" [drivers/mmc/host/wbsd.ko] undefined!
>>
>> Mathieu
>>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
prev parent reply other threads:[~2007-09-17 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 18:40 2.6.23-rc4-mm1 compile error for ppc 32 Mathieu Desnoyers
2007-09-06 23:00 ` Andrew Morton
2007-09-08 1:36 ` Nick Piggin
2007-09-08 16:42 ` Benjamin Herrenschmidt
2007-09-13 22:17 ` Andrew Morton
2007-09-15 13:32 ` Benjamin Herrenschmidt
2007-09-15 15:00 ` Mathieu Desnoyers
2007-09-17 20:31 ` Benjamin Herrenschmidt
2007-09-17 20:44 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EEE72B.1010008@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox