* [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
@ 2007-09-18 14:53 Rene Herman
2007-09-18 16:03 ` Nicolas Pitre
0 siblings, 1 reply; 5+ messages in thread
From: Rene Herman @ 2007-09-18 14:53 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Dmitry Torokhov, Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
Hi Nicolas.
Given that it's not checking for signals, I believe this one should be an
uninterruptible sleep instead?
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Rene.
[-- Attachment #2: schedule_timeout-ucb1400_ts.diff --]
[-- Type: text/plain, Size: 530 bytes --]
diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index f0cbcdb..670dd49 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
if (val & UCB_ADC_DAT_VALID)
break;
/* yield to other processes */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(1);
+ schedule_timeout_uninterruptible(1);
}
return UCB_ADC_DAT_VALUE(val);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
2007-09-18 14:53 [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one Rene Herman
@ 2007-09-18 16:03 ` Nicolas Pitre
2007-09-18 17:28 ` Rene Herman
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Pitre @ 2007-09-18 16:03 UTC (permalink / raw)
To: Rene Herman; +Cc: Dmitry Torokhov, Linux Kernel
On Tue, 18 Sep 2007, Rene Herman wrote:
> Hi Nicolas.
>
> Given that it's not checking for signals, I believe this one should be an
> uninterruptible sleep instead?
Probably.
Nicolas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
2007-09-18 16:03 ` Nicolas Pitre
@ 2007-09-18 17:28 ` Rene Herman
2007-09-18 17:38 ` Nicolas Pitre
0 siblings, 1 reply; 5+ messages in thread
From: Rene Herman @ 2007-09-18 17:28 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Dmitry Torokhov, Linux Kernel
On 09/18/2007 06:03 PM, Nicolas Pitre wrote:
> On Tue, 18 Sep 2007, Rene Herman wrote:
>
>> Hi Nicolas.
>>
>> Given that it's not checking for signals, I believe this one should be an
>> uninterruptible sleep instead?
>
> Probably.
Thanks. Should I send it somewhere or will you or Dmitry grab it?
Rene.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
2007-09-18 17:28 ` Rene Herman
@ 2007-09-18 17:38 ` Nicolas Pitre
2007-09-18 19:11 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Pitre @ 2007-09-18 17:38 UTC (permalink / raw)
To: Rene Herman; +Cc: Dmitry Torokhov, Linux Kernel
On Tue, 18 Sep 2007, Rene Herman wrote:
> On 09/18/2007 06:03 PM, Nicolas Pitre wrote:
>
> > On Tue, 18 Sep 2007, Rene Herman wrote:
> >
> > > Hi Nicolas.
> > >
> > > Given that it's not checking for signals, I believe this one should be an
> > > uninterruptible sleep instead?
> >
> > Probably.
>
> Thanks. Should I send it somewhere or will you or Dmitry grab it?
Please send it to Dmitry with my ACK.
Nicolas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
2007-09-18 17:38 ` Nicolas Pitre
@ 2007-09-18 19:11 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2007-09-18 19:11 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Rene Herman, Linux Kernel
On 9/18/07, Nicolas Pitre <nico@cam.org> wrote:
> On Tue, 18 Sep 2007, Rene Herman wrote:
>
> > On 09/18/2007 06:03 PM, Nicolas Pitre wrote:
> >
> > > On Tue, 18 Sep 2007, Rene Herman wrote:
> > >
> > > > Hi Nicolas.
> > > >
> > > > Given that it's not checking for signals, I believe this one should be an
> > > > uninterruptible sleep instead?
> > >
> > > Probably.
> >
> > Thanks. Should I send it somewhere or will you or Dmitry grab it?
>
> Please send it to Dmitry with my ACK.
>
I have it, thanks.
Next time please use my gmail or mail.ru account -
dtor_core@ameritech.net is dead.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-18 19:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-18 14:53 [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one Rene Herman
2007-09-18 16:03 ` Nicolas Pitre
2007-09-18 17:28 ` Rene Herman
2007-09-18 17:38 ` Nicolas Pitre
2007-09-18 19:11 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox