From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] i386/PAE: avoid temporarily inconsistent pte-s
Date: Wed, 19 Sep 2007 15:39:39 +0100 [thread overview]
Message-ID: <46F150CB.76E4.0078.0@novell.com> (raw)
One more of these issues (which were considered fixed a few releases
back): Other than on x86-64, i386 allows set_fixmap() to replace
already present mappings. Consequently, on PAE, care must be taken to
not update the high half of a pte while the low half is still holding
the old value.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
arch/i386/mm/pgtable.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc6/arch/i386/mm/pgtable.c 2007-09-14 17:38:47.000000000 +0200
+++ 2.6.23-rc6-i386-set-fixmap/arch/i386/mm/pgtable.c 2007-09-19 10:49:53.000000000 +0200
@@ -97,8 +97,7 @@ static void set_pte_pfn(unsigned long va
}
pte = pte_offset_kernel(pmd, vaddr);
if (pgprot_val(flags))
- /* <pfn,flags> stored as-is, to permit clearing entries */
- set_pte(pte, pfn_pte(pfn, flags));
+ set_pte_present(&init_mm, vaddr, pte, pfn_pte(pfn, flags));
else
pte_clear(&init_mm, vaddr, pte);
next reply other threads:[~2007-09-19 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 14:39 Jan Beulich [this message]
2007-09-19 16:09 ` [PATCH] i386/PAE: avoid temporarily inconsistent pte-s Andi Kleen
2007-09-19 16:16 ` Jan Beulich
2007-09-19 16:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F150CB.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox