From: Jeff Garzik <jgarzik@pobox.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
Date: Thu, 20 Sep 2007 00:10:54 -0400 [thread overview]
Message-ID: <46F1F2CE.7020300@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.64N.0709141135290.1926@blysk.ds.pg.gda.pl>
Maciej W. Rozycki wrote:
> Remove typedefs, volatiles and convert kmalloc()/memset() pairs to
> kcalloc(). Also reformat the surrounding clutter.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> On Thu, 13 Sep 2007, Jeff Garzik wrote:
>
>> Net driver patches should apply on top of netdev-2.6.git#upstream, which is
>> where changes to net drivers are queued for the next release.
>
> I can see Andrew has done some changes to the patch and applied it
> anyway, but here's a version I generated against your tree. Please feel
> free to choose either.
>
> You may be pleased (or less so) to hear that the version of sb1250-mac.c
> in your tree does not even build (because of
> 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not
> address it. I ran out of time in the evening, but I will send you a fix
> shortly. To be honest I think even with bulk changes it may be worth
> checking whether they do not break stuff. ;-)
hrm. I cannot get this to apply on top of linux-2.6.git,
netdev-2.6.git#upstream (prior to net-2.6.24 rebase) or
netdev-2.6.git#upstream (after net-2.6.24 rebase)
ACK the changes
next prev parent reply other threads:[~2007-09-20 4:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 12:20 [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc Maciej W. Rozycki
2007-09-10 16:58 ` Ralf Baechle
2007-09-13 3:58 ` Jeff Garzik
2007-09-13 14:13 ` Maciej W. Rozycki
2007-09-13 15:14 ` Ralf Baechle
2007-09-13 15:51 ` Jeff Garzik
2007-09-14 10:48 ` Maciej W. Rozycki
2007-09-20 4:10 ` Jeff Garzik [this message]
2007-09-20 14:23 ` Maciej W. Rozycki
2007-09-20 17:01 ` Jeff Garzik
2007-09-20 18:14 ` Maciej W. Rozycki
2007-09-29 5:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1F2CE.7020300@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox