From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbXITELU (ORCPT ); Thu, 20 Sep 2007 00:11:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750859AbXITELD (ORCPT ); Thu, 20 Sep 2007 00:11:03 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:55614 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbXITELB (ORCPT ); Thu, 20 Sep 2007 00:11:01 -0400 Message-ID: <46F1F2CE.7020300@pobox.com> Date: Thu, 20 Sep 2007 00:10:54 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: Ralf Baechle , Andrew Morton , netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc... References: <46E8B56E.7060705@pobox.com> <20070913151452.GB29665@linux-mips.org> <46E95C7F.1050302@pobox.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Maciej W. Rozycki wrote: > Remove typedefs, volatiles and convert kmalloc()/memset() pairs to > kcalloc(). Also reformat the surrounding clutter. > > Signed-off-by: Maciej W. Rozycki > --- > On Thu, 13 Sep 2007, Jeff Garzik wrote: > >> Net driver patches should apply on top of netdev-2.6.git#upstream, which is >> where changes to net drivers are queued for the next release. > > I can see Andrew has done some changes to the patch and applied it > anyway, but here's a version I generated against your tree. Please feel > free to choose either. > > You may be pleased (or less so) to hear that the version of sb1250-mac.c > in your tree does not even build (because of > 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not > address it. I ran out of time in the evening, but I will send you a fix > shortly. To be honest I think even with bulk changes it may be worth > checking whether they do not break stuff. ;-) hrm. I cannot get this to apply on top of linux-2.6.git, netdev-2.6.git#upstream (prior to net-2.6.24 rebase) or netdev-2.6.git#upstream (after net-2.6.24 rebase) ACK the changes