From: Pavel Emelyanov <xemul@openvz.org>
To: Andrew Morton <akpm@osdl.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH] Rework /proc/locks via seq_files and seq_list helpers (v2)
Date: Thu, 20 Sep 2007 12:46:09 +0400 [thread overview]
Message-ID: <46F23351.2020003@openvz.org> (raw)
In-Reply-To: <46F2330E.4040107@openvz.org>
Pavel Emelyanov wrote:
> Currently /proc/locks is shown with a proc_read function, but
> its behavior is rather complex as it has to manually handle
> current offset and buffer length. On the other hand, files
> that show objects from lists can be easily reimplemented using
> the sequential files and the seq_list_XXX() helpers.
>
> This saves (as usually) 16 lines of code and more than 200 from
> the .text section.
>
> This patch looks rather ugly, as diff often uses curly braces
> as not-changed lines, but I haven't managed to organize the
> code to make diff look better. Except for move the whole proc
> related stuff upper/lower in the locks.c file...
>
> Fixed the problem, spotted by J. Bruce Fields, about the fl
> variable reuse.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
OOPS! Please disregard, wrong comment was copied :(
prev parent reply other threads:[~2007-09-20 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 8:45 [PATCH] Rework /proc/locks via seq_files and seq_list helpers (v2) Pavel Emelyanov
2007-09-20 8:46 ` Pavel Emelyanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F23351.2020003@openvz.org \
--to=xemul@openvz.org \
--cc=akpm@osdl.org \
--cc=bfields@fieldses.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox