From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Guillaume Chazarain <guichaz@yahoo.fr>,
Jonathan Lim <jlim@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jay Lan <jlan@cthulhu.engr.sgi.com>,
Michael Neuling <mikey@neuling.org>
Subject: Re: Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5)
Date: Thu, 20 Sep 2007 17:47:53 +0530 [thread overview]
Message-ID: <46F264F1.30301@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070920121601.GA135@tv-sign.ru>
>> Andrew,
>>
>> Thanks for reviewing the patchset, this patch is on my review and test
>> queue (which has gotten rather long of late). I'll test it further and
>> get back.
>
> I still think this version is very wrong. It makes the ->signal->stats
> absolutely meaningless. Quoting myself:
>
Hi, Oleg,
Yes, I see, removing the memcpy is definitely wrong. Thanks for catching
it. I did not get a chance to review the patch, it's on my review queue,
but since you've reviewed it, I am very glad that you have and
identified potential issues.
Big Thanks!
--
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2007-09-20 12:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 13:53 [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID Guillaume Chazarain
2007-08-02 19:04 ` Andrew Morton
2007-08-19 19:34 ` Guillaume Chazarain
2007-08-20 17:01 ` Balbir Singh
2007-08-25 15:10 ` Guillaume Chazarain
2007-08-26 4:58 ` Balbir Singh
2007-08-26 9:44 ` Guillaume Chazarain
2007-08-31 3:02 ` Jonathan Lim
2007-08-31 7:24 ` Balbir Singh
2007-08-31 12:35 ` Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v3) Guillaume Chazarain
2007-09-13 0:18 ` Andrew Morton
2007-09-15 18:42 ` Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v4) Guillaume Chazarain
2007-09-17 22:23 ` Add all thread stats for TASKSTATS_CMD_ATTR_TGID (v5) Guillaume Chazarain
2007-09-18 15:29 ` Oleg Nesterov
2007-09-20 6:20 ` Andrew Morton
2007-09-20 8:54 ` Balbir Singh
2007-09-20 12:16 ` Oleg Nesterov
2007-09-20 12:17 ` Balbir Singh [this message]
2007-09-07 23:37 ` [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID Jonathan Lim
2007-09-10 13:03 ` Guillaume Chazarain
2007-08-15 7:15 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F264F1.30301@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=guichaz@yahoo.fr \
--cc=jlan@cthulhu.engr.sgi.com \
--cc=jlim@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).