From: Simon Arlott <simon@fire.lp0.eu>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;" assignments
Date: Sun, 23 Sep 2007 16:36:08 +0100 [thread overview]
Message-ID: <46F687E8.3010101@simon.arlott.org.uk> (raw)
In-Reply-To: <46F68708.6070409@simon.arlott.org.uk>
Cleanup code by removing "ret = ret;" assignments.
Signed-Off-By: Simon Arlott <simon@fire.lp0.eu>
---
drivers/usb/atm/cxacru.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 35308a8..bb3169c 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -496,7 +496,6 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
if (ret < 0) {
usb_err(instance->usbatm, "submit of read urb for cm %#x failed (%d)\n",
cm, ret);
- ret = ret;
goto fail;
}
@@ -514,21 +513,18 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
if (ret < 0) {
usb_err(instance->usbatm, "submit of write urb for cm %#x failed (%d)\n",
cm, ret);
- ret = ret;
goto fail;
}
ret = cxacru_start_wait_urb(instance->snd_urb, &instance->snd_done, NULL);
if (ret < 0) {
usb_err(instance->usbatm, "send of cm %#x failed (%d)\n", cm, ret);
- ret = ret;
goto fail;
}
ret = cxacru_start_wait_urb(instance->rcv_urb, &instance->rcv_done, &actlen);
if (ret < 0) {
usb_err(instance->usbatm, "receive of cm %#x failed (%d)\n", cm, ret);
- ret = ret;
goto fail;
}
if (actlen % CMD_PACKET_SIZE || !actlen) {
--
1.5.0.1
--
Simon Arlott
next prev parent reply other threads:[~2007-09-23 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 15:32 [PATCH 1/2] cxacru: Use appropriate logging for errors Simon Arlott
2007-09-23 15:34 ` [PATCH 2/3] cxacru: Reduce initialisation delay Simon Arlott
2007-09-23 16:23 ` Duncan Sands
2007-09-23 18:33 ` Simon Arlott
2007-09-23 15:36 ` Simon Arlott [this message]
2007-09-23 16:20 ` [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;" assignments Duncan Sands
2007-09-23 18:36 ` Simon Arlott
2007-09-24 18:32 ` Greg KH
2007-09-25 19:20 ` [PATCH] cxacru: Use appropriate logging for errors Simon Arlott
2007-09-23 16:17 ` [PATCH 1/2] " Duncan Sands
2007-09-23 18:44 ` [PATCH 1/2 (v2)] " Simon Arlott
2007-09-23 19:26 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F687E8.3010101@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox