From: Simon Arlott <simon@fire.lp0.eu>
To: Duncan Sands <duncan.sands@math.u-psud.fr>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 2/3] cxacru: Reduce initialisation delay
Date: Sun, 23 Sep 2007 19:33:02 +0100 [thread overview]
Message-ID: <46F6B15E.7020601@simon.arlott.org.uk> (raw)
In-Reply-To: <200709231823.22957.duncan.sands@math.u-psud.fr>
On 23/09/07 17:23, Duncan Sands wrote:
> Hi Simon,
>
>> + usb_info(usbatm, "started firmware\n");
> ...
>> + usb_info(usbatm, "loaded config data\n");
>
> maybe these should be debug messages. When are they useful?
They are probably only useful as debug messages - although it
may be desirable to know when the configuration has been set.
Also... it doesn't make sense to load the configuration only
in heavy_init - if the configuration is changed then there's
no way in the module to resend it without powering the device
down and up. Some sysfs parameters to change configuration
could be useful... except there's no information as to what
these settings are.
--
Simon Arlott
next prev parent reply other threads:[~2007-09-23 18:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 15:32 [PATCH 1/2] cxacru: Use appropriate logging for errors Simon Arlott
2007-09-23 15:34 ` [PATCH 2/3] cxacru: Reduce initialisation delay Simon Arlott
2007-09-23 16:23 ` Duncan Sands
2007-09-23 18:33 ` Simon Arlott [this message]
2007-09-23 15:36 ` [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;" assignments Simon Arlott
2007-09-23 16:20 ` Duncan Sands
2007-09-23 18:36 ` Simon Arlott
2007-09-24 18:32 ` Greg KH
2007-09-25 19:20 ` [PATCH] cxacru: Use appropriate logging for errors Simon Arlott
2007-09-23 16:17 ` [PATCH 1/2] " Duncan Sands
2007-09-23 18:44 ` [PATCH 1/2 (v2)] " Simon Arlott
2007-09-23 19:26 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F6B15E.7020601@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=duncan.sands@math.u-psud.fr \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox