Re: 2.6.23-rc7-mm1

Kamalesh Babulal
2007-09-24T19:41:51Z

Hi Andrew,

The build fails with following error

CC drivers/block/ps3disk.o
drivers/block/ps3disk.c: In function ‘ps3disk_scatter_gather’:
drivers/block/ps3disk.c:115: error: ‘bio’ undeclared (first use in this
function)
drivers/block/ps3disk.c:115: error: (Each undeclared identifier is
reported only once
drivers/block/ps3disk.c:115: error: for each function it appears in.)
drivers/block/ps3disk.c:115: error: ‘j’ undeclared (first use in this
function)
drivers/block/ps3disk.c:116: error: implicit declaration of function
‘bio_kunmap_bvec’
make[2]: *** [drivers/block/ps3disk.o] Error 1
make[1]: *** [drivers/block] Error 2
make: *** [drivers] Error 2

The function bio_kunmap_bvec is missing.I tried checking the git-block.patch
as well as the linux/kernel/git/axboe/linux-2.6-block.git and did not
find this function.

Previously this function was replaced by __bio_kunmap_atomic();
This patch does not solves the implicit "declaration of function
‘bio_kunmap_bvec’"

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com
<mailto:kamalesh@linux.vnet.ibm.com>>
---

--- linux-2.6.23-rc7/drivers/block/ps3disk.c 2007-09-24 20:50:41.000000000 +0530
+++ linux-2.6.23-rc7/drivers/block/~ps3disk.c 2007-09-24 20:50:59.000000000 +0530
@@ -112,7 +112,7 @@ static void ps3disk_scatter_gather(struc
else
memcpy(buf, dev->bounce_buf+offset, size);
offset += size;
- flush_kernel_dcache_page(bio_iovec_idx(bio, j)->bv_page);
+ flush_kernel_dcache_page(bio_iovec_idx(iter.bio, iter.i)->bv_page);
bio_kunmap_bvec(bvec, flags);
i++;
}

--

Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.