Re: 2.6.23-rc7-mm1

Jens Axboe
2007-09-24T16:56:01Z

On Mon, Sep 24 2007, Cedric Le Goater wrote:
> Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/
>
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c: In function `dasd_eckd_build_cp':
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1181: error: syntax error before "struct"
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: error: `iter' undeclared (first use in this function)
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: error: (Each undeclared identifier is reported only once
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: error: for each function it appears in.)
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: error: `bv' undeclared (first use in this function)
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: warning: left-hand operand of comma expression has no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: warning: left-hand operand of comma expression has no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1257: warning: left-hand operand of comma expression has no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1257: warning: left-hand operand of comma expression has no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: warning: statement with no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1209: warning: statement with no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1257: warning: statement with no effect
> /home/clg/linux/2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c:1257: warning: statement with no effect
> make[3]: *** [drivers/s390/block/dasd_eckd.o] Error 1
> make[2]: *** [drivers/s390/block] Error 2
>
> Signed-off-by: Cedric Le Goater <clg@fr.ibm.com>
> ---
> drivers/s390/block/dasd_eckd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: 2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c
> ===================================================================
> --- 2.6.23-rc7-mm1.orig/drivers/s390/block/dasd_eckd.c
> +++ 2.6.23-rc7-mm1/drivers/s390/block/dasd_eckd.c
> @@ -1176,7 +1176,7 @@ dasd_eckd_build_cp(struct dasd_device *
> struct LO_eckd_data *LO_data;
> struct dasd_ccw_req *cqr;
> struct ccw1 *ccw;
> - struct req_iterator iter
> + struct req_iterator iter;
> struct bio_vec *bv;
> char *dst;
> unsigned int blksize, blk_per_trk, off;

Oops, looks like neither Neil nor I cross compiled this on s390. Thanks,
I'll apply it.

--
Jens Axboe