Re: [Patch 1/2] Trace code and documentation (resend)

David Wilder
2007-09-24T15:38:46Z

Christoph Hellwig wrote:
> On Fri, Sep 21, 2007 at 09:23:28PM -0700, David J. Wilder wrote:
>> My last posting was mangled by my mailer. I hope this one is better.
>> Also corrected Randy's concerns.
>>
>> Please see previous posting for more information:
>> http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2)
>>
>> Note: this patch requires "[Patch 2/2] Relay reset consumed" is applied.
>>
>> ---------<start of patch>------------
>> Trace - Provides tracing primitives
>>
>> Signed-off-by: Tom Zanussi <zanussi@us.ibm.com>
>> Signed-off-by: Martin Hunt <hunt@redhat.com>
>> Signed-off-by: David Wilder <dwilder@us.ibm.com>
>> ---
>> Documentation/trace/src/Makefile | 7 +
>> Documentation/trace/src/README | 18 +
>> Documentation/trace/src/fork_trace.c | 119 +++++++
>> Documentation/trace/trace.txt | 164 ++++++++++
>
> NACK, don't put code into Documentation/. Put it into kernel as it's
> actually useful kernel code.

Are you suggesting moving the example code into kernel? Or complaining
about example code in /Documentation?

And add clone,exec and exit while you're at it.

Hu? A syscall tracer sounds like a nice idea but that is not what I am
trying to accomplish. I will let Systemtap handle that.