public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Valette <Eric.Valette@Free.fr>
To: Rob Hussey <robjhussey@gmail.com>
Cc: "ポール・ロラン Paul Rolland" <rol@witbe.net>,
	flamingice@sourmilk.net, andreamrl@tiscali.it,
	linux-kernel@vger.kernel.org,
	"Johannes Berg" <johannes@sipsolutions.net>,
	torvalds@osdl.org
Subject: Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module.
Date: Tue, 25 Sep 2007 10:05:56 +0200	[thread overview]
Message-ID: <46F8C164.4080604@Free.fr> (raw)
In-Reply-To: <6b8cef970709151419r7561e950jcc35f4a50661273f@mail.gmail.com>

Rob Hussey wrote:
> On 9/15/07, ポール・ロラン Paul Rolland <rol@witbe.net> wrote:
>   
>> Hi Eric,
>>
>> On Sat, 15 Sep 2007 20:30:14 +0200
>> Eric Valette <eric.valette@free.fr> wrote:
>>
>>     
>>> Rob Hussey wrote:
>>>       
>>>> On 9/15/07, Eric Valette <eric.valette@free.fr> wrote:
>>>>         
>>>>> Eric Valette wrote:
>>>>>
>>>>>           
>>> Thanks for your help: it does indeed fix the problem.
>>>       
>> Nice it works for you too !
>>
>>     
>>> Now I have two side questions:
>>>       - the code is no more symetric "subsys_initcall" -> "module_exit".
>>> Do not know if it is "normal" but I love symmetry in code :-). Did not test
>>> it still works as a module...
>>>       
>> Symmetry is not broken, as we have :
>> #define subsys_initcall(fn)             module_init(fn)
>> in include/linux/init.h where compiling as a module, and when not compiling
>> as a module, I doubt the exit function is called unless you are shuting
>> down your machine...
>>
>>     
>>>       - Who takes the responsability to push a patch to Linus? I guess it
>>> is urgent unless he plans a rc7
>>>       
>> Good point ! I expect the patches to be already in some queue waiting to be
>> pulled !
>>     
>
> The patches are on their way to making it into 2.6.23:
> http://marc.info/?l=linux-netdev&m=118986368303529&w=2
>
> Regards,
> Rob
>   
I'm a little bit worried as rc8 is out and ots still not in git.

-- eric


      reply	other threads:[~2007-09-25  8:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-15 14:07 rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module Eric Valette
2007-09-15 14:27 ` Eric Valette
2007-09-15 15:38   ` Paul Rolland
2007-09-15 16:28   ` Rob Hussey
2007-09-15 17:41     ` Paul Rolland
2007-09-15 18:30     ` Eric Valette
2007-09-15 18:51       ` Paul Rolland
2007-09-15 19:00         ` Eric Valette
2007-09-17  9:48           ` Johannes Berg
2007-09-17 11:44             ` Eric Valette
2007-09-15 21:19         ` Rob Hussey
2007-09-25  8:05           ` Eric Valette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F8C164.4080604@Free.fr \
    --to=eric.valette@free.fr \
    --cc=andreamrl@tiscali.it \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robjhussey@gmail.com \
    --cc=rol@witbe.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox