Re: 2.6.23-rc8-mm1 -- powerpc link failure

Andrew Morton
2007-09-27T17:20:23Z

On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:

> On Thu, 27 Sep 2007, Andy Whitcroft wrote:
>
> > Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we
> > have three options from here:
> > 1) update the compiler support list to exclude these compilers, or
> > 2) back this change out, or
> > 3) switch to the version not using __weak.
> > The latter seems to be the least intrusive change. As no-one closer to
> > the problem is stepping up to make the decision I will propose we go
> > with the third option here.
>
> Andrew,
>
> if you agree with Andy that we should support compilers that don't work
> with __weak, please drop i386-and-x86_64-randomize-brk.patch and replace
> it with the one below instead (this has been already posted at
> http://lkml.org/lkml/2007/8/31/113). Thanks.
>

We have quite a few instances of __weak in there. What is special about
this one?

>
> From: Jiri Kosina <jkosina@suse.cz>
>
> i386 and x86_64: randomize brk()

That's a better patch anyway. We often use __weak because people
can't be bothered doing all that editing.