Re: 2.6.23-rc8-mm1 -- powerpc link failure

Andrew Morton
2007-09-27T22:14:36Z

On Thu, 27 Sep 2007 14:13:21 +0200 (CEST)
Jiri Kosina <jkosina@suse.cz> wrote:

> i386 and x86_64: randomize brk()
>
> ...
>
> --- a/arch/x86_64/ia32/ia32_binfmt.c
> +++ b/arch/x86_64/ia32/ia32_binfmt.c
> @@ -262,6 +262,7 @@ static void elf32_init(struct pt_regs *);
> #define ARCH_HAS_SETUP_ADDITIONAL_PAGES 1
> #define arch_setup_additional_pages syscall32_setup_pages
> extern int syscall32_setup_pages(struct linux_binprm *, int exstack);
> +extern void arch_randomize_brk(void);
>
> #include "../../../fs/binfmt_elf.c"

Is this sinful extern-decl-in-C acually needed?

> index b4fbe47..5a1adf9 100644
> --- a/include/asm-x86_64/elf.h
> +++ b/include/asm-x86_64/elf.h
> @@ -177,4 +177,6 @@ do if (vdso_enabled) { \
>
> #endif
>
> +extern void arch_randomize_brk(void);
> +
> #endif

Because we already have a declaration in the correct place?