Re: 2.6.23-rc8-mm1

Badari Pulavarty
2007-09-25T22:03:19Z

Hi Andy,

One the patch you created in -mm is causing compile warning.
Here is the fix. Please verify.

Thanks,
Badari

arch/powerpc/mm/init_64.c: In function `vmemmap_populated':
arch/powerpc/mm/init_64.c:211: warning: passing arg 1 of `vmemmap_section_start' makes pointer from integer without a cast

vmemmap_section_start() gets called with an argument which is unsigned long.

Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>

Index: linux-2.6.23-rc8/arch/powerpc/mm/init_64.c
===================================================================
--- linux-2.6.23-rc8.orig/arch/powerpc/mm/init_64.c 2007-09-25 09:18:13.000000000 -0700
+++ linux-2.6.23-rc8/arch/powerpc/mm/init_64.c 2007-09-25 14:50:44.000000000 -0700
@@ -189,10 +189,9 @@ void pgtable_cache_init(void)
* do this by hand as the proffered address may not be correctly aligned.
* Subtraction of non-aligned pointers produces undefined results.
*/
-unsigned long __meminit vmemmap_section_start(struct page *page)
+unsigned long __meminit vmemmap_section_start(unsigned long page)
{
- unsigned long offset = ((unsigned long)page) -
- ((unsigned long)(vmemmap));
+ unsigned long offset = page - ((unsigned long)(vmemmap));

/* Return the pfn of the start of the section. */
return (offset / sizeof(struct page)) & PAGE_SECTION_MASK;