Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

Jeff Garzik
2007-09-26T14:33:45Z

Alan Cox wrote:
>>> NAK - mmio is an iomap so writel and readl are the wrong things to use
>> The patch is consistent with the rest of the driver.
>> You are welcome to submit a patch to convert ahci to using ioremap.
>
> You could just flip the relevant function to use ioread while you are
> tidying it up, instead of spreading new bugs into the code.

No, as I just noted above, the proper fix for this driver is to use
ioremap rather than pci_iomap.

Adding support to ahci for legacy PIO is completely pointless.

Jeff