* [PATCH] Remove unused member from nsproxy
@ 2007-09-26 13:14 Pavel Emelyanov
2007-09-26 13:28 ` Serge E. Hallyn
2007-09-26 13:31 ` Cedric Le Goater
0 siblings, 2 replies; 4+ messages in thread
From: Pavel Emelyanov @ 2007-09-26 13:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: Serge Hallyn, Linux Containers, Linux Kernel Mailing List
The nslock spinlock is not used in the kernel at all.
Remove it.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/include/linux/init_task.h b/include/linux/init_task.h
index a3f2541..cae35b6 100644
--- a/include/linux/init_task.h
+++ b/include/linux/init_task.h
@@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
#define INIT_NSPROXY(nsproxy) { \
.pid_ns = &init_pid_ns, \
.count = ATOMIC_INIT(1), \
- .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
.uts_ns = &init_uts_ns, \
.mnt_ns = NULL, \
INIT_NET_NS(net_ns) \
diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
index 4d564d8..0e66b57 100644
--- a/include/linux/nsproxy.h
+++ b/include/linux/nsproxy.h
@@ -23,7 +23,6 @@ struct pid_namespace;
*/
struct nsproxy {
atomic_t count;
- spinlock_t nslock;
struct uts_namespace *uts_ns;
struct ipc_namespace *ipc_ns;
struct mnt_namespace *mnt_ns;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unused member from nsproxy
2007-09-26 13:14 [PATCH] Remove unused member from nsproxy Pavel Emelyanov
@ 2007-09-26 13:28 ` Serge E. Hallyn
2007-09-26 13:31 ` Cedric Le Goater
1 sibling, 0 replies; 4+ messages in thread
From: Serge E. Hallyn @ 2007-09-26 13:28 UTC (permalink / raw)
To: Pavel Emelyanov
Cc: Andrew Morton, Serge Hallyn, Linux Containers,
Linux Kernel Mailing List
Quoting Pavel Emelyanov (xemul@openvz.org):
> The nslock spinlock is not used in the kernel at all.
> Remove it.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
> ---
>
> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
> index a3f2541..cae35b6 100644
> --- a/include/linux/init_task.h
> +++ b/include/linux/init_task.h
> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
> #define INIT_NSPROXY(nsproxy) { \
> .pid_ns = &init_pid_ns, \
> .count = ATOMIC_INIT(1), \
> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
> .uts_ns = &init_uts_ns, \
> .mnt_ns = NULL, \
> INIT_NET_NS(net_ns) \
> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
> index 4d564d8..0e66b57 100644
> --- a/include/linux/nsproxy.h
> +++ b/include/linux/nsproxy.h
> @@ -23,7 +23,6 @@ struct pid_namespace;
> */
> struct nsproxy {
> atomic_t count;
> - spinlock_t nslock;
> struct uts_namespace *uts_ns;
> struct ipc_namespace *ipc_ns;
> struct mnt_namespace *mnt_ns;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unused member from nsproxy
2007-09-26 13:14 [PATCH] Remove unused member from nsproxy Pavel Emelyanov
2007-09-26 13:28 ` Serge E. Hallyn
@ 2007-09-26 13:31 ` Cedric Le Goater
2007-09-26 13:37 ` Pavel Emelyanov
1 sibling, 1 reply; 4+ messages in thread
From: Cedric Le Goater @ 2007-09-26 13:31 UTC (permalink / raw)
To: Pavel Emelyanov
Cc: Andrew Morton, Linux Containers, Linux Kernel Mailing List
Pavel Emelyanov wrote:
> The nslock spinlock is not used in the kernel at all.
it's also useless now that you have put some RCU rules around it.
right ?
C.
> Remove it.
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> ---
>
> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
> index a3f2541..cae35b6 100644
> --- a/include/linux/init_task.h
> +++ b/include/linux/init_task.h
> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
> #define INIT_NSPROXY(nsproxy) { \
> .pid_ns = &init_pid_ns, \
> .count = ATOMIC_INIT(1), \
> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
> .uts_ns = &init_uts_ns, \
> .mnt_ns = NULL, \
> INIT_NET_NS(net_ns) \
> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
> index 4d564d8..0e66b57 100644
> --- a/include/linux/nsproxy.h
> +++ b/include/linux/nsproxy.h
> @@ -23,7 +23,6 @@ struct pid_namespace;
> */
> struct nsproxy {
> atomic_t count;
> - spinlock_t nslock;
> struct uts_namespace *uts_ns;
> struct ipc_namespace *ipc_ns;
> struct mnt_namespace *mnt_ns;
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unused member from nsproxy
2007-09-26 13:31 ` Cedric Le Goater
@ 2007-09-26 13:37 ` Pavel Emelyanov
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Emelyanov @ 2007-09-26 13:37 UTC (permalink / raw)
To: Cedric Le Goater
Cc: Andrew Morton, Linux Containers, Linux Kernel Mailing List
Cedric Le Goater wrote:
> Pavel Emelyanov wrote:
>> The nslock spinlock is not used in the kernel at all.
>
> it's also useless now that you have put some RCU rules around it.
> right ?
Exactly!
> C.
>
>> Remove it.
>> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>>
>> ---
>>
>> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
>> index a3f2541..cae35b6 100644
>> --- a/include/linux/init_task.h
>> +++ b/include/linux/init_task.h
>> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
>> #define INIT_NSPROXY(nsproxy) { \
>> .pid_ns = &init_pid_ns, \
>> .count = ATOMIC_INIT(1), \
>> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
>> .uts_ns = &init_uts_ns, \
>> .mnt_ns = NULL, \
>> INIT_NET_NS(net_ns) \
>> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
>> index 4d564d8..0e66b57 100644
>> --- a/include/linux/nsproxy.h
>> +++ b/include/linux/nsproxy.h
>> @@ -23,7 +23,6 @@ struct pid_namespace;
>> */
>> struct nsproxy {
>> atomic_t count;
>> - spinlock_t nslock;
>> struct uts_namespace *uts_ns;
>> struct ipc_namespace *ipc_ns;
>> struct mnt_namespace *mnt_ns;
>> _______________________________________________
>> Containers mailing list
>> Containers@lists.linux-foundation.org
>> https://lists.linux-foundation.org/mailman/listinfo/containers
>>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-26 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-26 13:14 [PATCH] Remove unused member from nsproxy Pavel Emelyanov
2007-09-26 13:28 ` Serge E. Hallyn
2007-09-26 13:31 ` Cedric Le Goater
2007-09-26 13:37 ` Pavel Emelyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox