From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09AD53E6398 for ; Fri, 20 Mar 2026 18:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030692; cv=none; b=HHgP8zBb1TerRJY2rUZEmgAtdIbPS5RIWcf/gXPBg0C73Ohc2UApha8uvPv82aoct+blMqTcVdXtJRc6eGFEwzsVjcrZz7BwMhterIFq0W5e1zqywyWchYUhL/zUgcxOTSFJt77hXmck6aHwQ8b7XSJN9sdZSIisTvFTF/bbzp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030692; c=relaxed/simple; bh=TveWmGtGF+NJQXSywEPJlwFGnrefgR4bV3UdzJamrTs=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=BSgZharUbS8p9HzvMWxqqieUIUVRw11wBjLItSfSSzuGhjMHC1Mp/sjd9H/Pmyogg8KjMm46ZV11X9sTtlDjGJ9A28s53IyODUfR38vvLoZgM18eZIVMchFqttgcEVxaggGBxFo94GNbbApByUNh+gJ0nfUyyfIqFxSLTbD6D28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cXBmeHio; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cXBmeHio" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so16711945e9.1 for ; Fri, 20 Mar 2026 11:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030688; x=1774635488; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gzgXZ3NiL5XfSi1Gl8c37CbUSVUYSABbSljKRuEeP+I=; b=cXBmeHioXEbh2o1U349rQL9HP8fHUf5F6ct2aryUjcp6BLhjFmXWqCLBzVBW5Wi13K iyEByVAbaHragCM875vXbtWe+wbIEkVy+Dr0GedhQQBFmLG6tHOHFpIdJhNx/YWewQJL kWIQkHfpxloYpwmcUa0VnRAXa4POJbbtNmgl3dKqau52ue/ff17waWkNVMUGZM8yLqVO b08Z08s5E1l3J4cdExrI5r6zh4I0MD80+DgnU3gRwOcpFW+XMWL3A/Oxm8UWhy3YOs11 X6B0gr0frgGK2iImaYYTVxeAYy3q8wmoxP5XN8pto8bODYelG+ypInnO8l/TYzYOloVs t+kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030688; x=1774635488; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gzgXZ3NiL5XfSi1Gl8c37CbUSVUYSABbSljKRuEeP+I=; b=erNta/Ab1aU0jbBRmOcp2+JaK7xmeJq786qryKQYCpiZRjcchqs9OuA+zym+MRCWKA mZnWMD418snfGkctyTVXbdo3imlz3jh/Ow3aszZKkk01qhXJXzwYv6iwNpLZ+SgljX0O E7N3TVRsB9QxXIwIOzW1kumg9xcf0NLj8axdvriAQWw5XM6CBBsssNaq96TJUqoP3oxP B2aroy5ek2TaUk5wNUkyuzYKjoOrwGY3UUkTPEmR4tnM5qYkeV00MjyFgkHmWyTottFu 1sQ6EcERnAi78w+7awJVNtda3EevK+liLUhD5TCmQicUmzIfbc9lyAkXvb9cV4auzc6U bAMw== X-Forwarded-Encrypted: i=1; AJvYcCWoFJFunG5/gvPLWAwOej3V0p0h9xanNS4fwpyzwgcq0ATSmeAE0EXduvAtlOFrj+p5Azt1vi8RC25R1W8=@vger.kernel.org X-Gm-Message-State: AOJu0YykVjuiaZmQVTLA/IcRzIJW8RLbjRDyjVUUBgSe56oYaGhvM+SG p6zGSaSOMNNAt2X+sANQD3fm5v5ewgDE1axnu4q5EoAd1hctpkp4yDtz X-Gm-Gg: ATEYQzyLLW8wftrTIVyOTCzIvnsCTP7cx+kBARM5ZZu640xtd71yrz9yeoe7esQG7LO 4q4F53A8JVtJQQzI3vBaMEBUUSN8OMpjg66Bs8TnLZ8Iqw85+kHWHmiNhx5vera0llSUD+HQru9 6TfdIJEJqmI6B+BDpD+UkGVa2+7D8IX2BJir3lEtg4IBYOfBWVKjjuIIUghuwbmyS2eK4DOJCkG CmZyBX3Dg0K0hhAtteHSl9rb20bri84Bk4esITKw49zxB2r7Vgnwyq70t/KRRNvX6ncAWr3vvFk Y4z3PY7Tw1q0i6Hqz4xZ7s9QlNXH2xTVwttzFW4GriIXmwNrGnN5oVP119PQHYF3lrhSXvGbZfx 1TK97RN6oGcv4ADPccVacAN2xU/u2dQ6As8lm7ZdUPF0YmAHgJieUAc4Dio9TTxhUvMGJzMQmQk Y7rLyAIJKUF+OXa1yU6/ww+4y36g+xypllaXKEfEPjx67837Y6SGyfBNE= X-Received: by 2002:a05:600d:8449:b0:477:9890:9ab8 with SMTP id 5b1f17b1804b1-486fe8a2bafmr52731085e9.3.1774030688082; Fri, 20 Mar 2026 11:18:08 -0700 (PDT) Received: from smtpclient.apple ([2001:912:1ac0:1e00:48e8:da36:b41d:78fa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487031790fdsm12424335e9.3.2026.03.20.11.18.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2026 11:18:07 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: [PATCH net-next v9 2/4] net: phy: realtek: add RTL8224 pair order support From: Damien Dejean In-Reply-To: <20260320082156.GX1753385@horms.kernel.org> Date: Fri, 20 Mar 2026 19:17:56 +0100 Cc: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org, kuba@kernel.org, maxime.chevallier@bootlin.com, pabeni@redhat.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com Content-Transfer-Encoding: quoted-printable Message-Id: <46FAC4A6-9462-45BC-B17C-B7F5F19F0ADB@gmail.com> References: <20260318215502.106528-1-dam.dejean@gmail.com> <20260318215502.106528-3-dam.dejean@gmail.com> <20260320082156.GX1753385@horms.kernel.org> To: Simon Horman X-Mailer: Apple Mail (2.3864.400.21) > Le 20 mars 2026 =C3=A0 09:21, Simon Horman a =C3=A9cr= it : >=20 > Checkpatch warns that ENOSYS only means 'invalid syscall nr'. >=20 > Looking over the implementation of of_property_read_u32() it seems to = me > that -EINVAL is sufficient to detect that a property is not present. = Which > may be appropriate here. I added the check on -ENOSYS because in v8 Jakub commented [1] on the = fact that if the kernel is built with CONFIG_OF=3Dn, of_property_read_u32() = will return ENOSYS. If ENOSYS is not handled there, then the call will return = an error while it shouldn=E2=80=99t. Damien [1] https://lkml.org/lkml/2026/3/17/2464 >=20 > Likewise in patch 4/4. >=20 > Using a quick grep of the tree, I do notice the same pattern as above = is > also present (only?) in aquantia_main.c. So depending on the outcome = of this > discussion it might be appropriate to update that too. >=20 >> + >> + if (ret) >> + return ret; >> + >> + if (order & ~1) >> + return -EINVAL; >> + >> + return rtl8224_package_modify_mmd(phydev, MDIO_MMD_VEND1, >> + RTL8224_VND1_MDI_PAIR_SWAP, >> + BIT(port_offset), >> + order ? BIT(port_offset) : 0); >> +} >> + >> +static int rtl8224_config_init(struct phy_device *phydev) >> +{ >> + return rtl8224_mdi_config_order(phydev); >> +} >=20 > ... >=20 >> @@ -2395,6 +2457,8 @@ static struct phy_driver realtek_drvs[] =3D { >> PHY_ID_MATCH_EXACT(0x001ccad0), >> .name =3D "RTL8224 2.5Gbps PHY", >> .flags =3D PHY_POLL_CABLE_TEST, >> + .probe =3D rtl8224_probe, >> + .config_init =3D rtl8224_config_init, >> .get_features =3D rtl822x_c45_get_features, >> .config_aneg =3D rtl822x_c45_config_aneg, >> .read_status =3D rtl822x_c45_read_status, >> --=20 >> 2.47.3 >>=20