Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

roel
2007-09-26T21:40:53Z

Erez Zadok wrote:

> @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist)
>
> BUG_ON(!S_ISDIR(dentry->d_inode->i_mode));
>
> - if ((err = unionfs_partial_lookup(dentry)))
> + if (unlikely((err = unionfs_partial_lookup(dentry))))
> goto out;
>
> bstart = dbstart(dentry);

Is it bad to leave this assignment within the unlikely()?