public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Jones <pjones@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>
Cc: Konrad Rzeszutek <konrad@darnok.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	linux-kernel@vger.kernel.org,
	Konrad Rzeszutek <konradr@redhat.com>,
	konradr@linux.vnet.ibm.com
Subject: Re: [PATCH] Add iSCSI iBFT support.
Date: Thu, 27 Sep 2007 13:51:04 -0400	[thread overview]
Message-ID: <46FBED88.8060200@redhat.com> (raw)
In-Reply-To: <46FBE5D2.6090306@zytor.com>

H. Peter Anvin wrote:
> Peter Jones wrote:
>>> It should, presumably, depend on ACPI, rather than on X86...?
>> Actually no.  That /should/ be the correct answer, but none of the
>> hardware vendors actually provide the table via ACPI yet.  Also, if they
>> did, the support for /sys/firmware/acpi/tables/* would be sufficient
>> instead of having this code *at all*.
>>
> 
> Is there anything other than the discovery which is braindead about
> iBFT?  If so, can the tables code be taught to look for this additional
> table instead of having all its own mechanism?

Well, the code for the the generic ACPI table sysfs functionality is 
expecting to find the tables indexed in the RSDT.  This is essentially 
what the iBFT spec's authors seem to have planned, but it's simply never 
been implemented in the firmware.

AFAICS, it's technically feasible to remove the sysfs parts of this code 
entirely, make the probe code build a fake ACPI table header, and then 
add it explicitly if present at the end of acpi_system_sysfs_init() .

I don't know how the ACPI guys would feel about that.  Len, thoughts?

-- 
   Peter

  reply	other threads:[~2007-09-27 17:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 18:46 [PATCH] Add iSCSI iBFT support Konrad Rzeszutek
2007-09-26 19:37 ` roel
2007-09-26 21:10 ` Greg KH
2007-09-27  0:08   ` Konrad Rzeszutek
2007-09-27  2:04     ` Greg KH
2007-09-26 21:13 ` Randy Dunlap
2007-09-27  0:16   ` Konrad Rzeszutek
2007-09-26 21:29 ` Randy Dunlap
2007-09-27  0:52   ` Konrad Rzeszutek
     [not found]     ` <14e4363b0709261817t5f0b1922m99c24549ce316de8@mail.gmail.com>
2007-09-27  4:00       ` Randy Dunlap
2007-09-27  4:29     ` Randy Dunlap
2007-09-27 17:06     ` H. Peter Anvin
2007-09-27 17:12       ` Peter Jones
2007-09-27 17:18         ` H. Peter Anvin
2007-09-27 17:51           ` Peter Jones [this message]
2007-09-27 20:50             ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FBED88.8060200@redhat.com \
    --to=pjones@redhat.com \
    --cc=hpa@zytor.com \
    --cc=konrad@darnok.org \
    --cc=konradr@linux.vnet.ibm.com \
    --cc=konradr@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox